linux-kernel - [PATCH 1/2] ALSA: hda/realtek: Add generic quirk for Bass speaker DAC avoidance

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260201231216.1655154-2-samuel@dionne-riel.com>
Date: Sun,  1 Feb 2026 18:12:14 -0500
From: Samuel Dionne-Riel <samuel@...nne-riel.com>
To: Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>
Cc: Samuel Dionne-Riel <samuel@...nne-riel.com>,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH 1/2] ALSA: hda/realtek: Add generic quirk for Bass speaker DAC avoidance

This change is for the follow-up commit, where the match on the specific
device (Minisforum V3 SE) is added.

This pattern (re-routing the bass speakers off of a DAC without volume
control) seems common enough that having a "model" to match against and
quickly use to verify may be worthwhile.

The alc285_fixup_thinkpad_x1_gen7 routing was selected, amongst the
different options, as it should allow tuning the ratio between both
speaker set.

The routing was verified using `hda-verb`, and picking either 0x00 or
0x01. Either routin made the volume of the bass speakers controllable.

    hda-verb /dev/snd/hwC1D0 0x17 SET_CONNECT_SEL 0x01

Signed-off-by: Samuel Dionne-Riel <samuel@...nne-riel.com>

---

It may be worthwhile to clean-up behind and make the other fixups
re-routing `0x17` from `0x06` to either `0x02` or `0x03` also use the
same routing. It's a bit confusing, determining which routing to choose
when adding one for a device.

 - alc289_fixup_asus_ga401
 - alc295_fixup_disable_dac3

Might need to be checked (and re-used within a chain):

 - alc287_fixup_yoga9_14iap7_bass_spk_pin
 - alc245_fixup_hp_spectre_x360_eu0xxx
 - alc245_fixup_hp_spectre_x360_16_aa0xxx

I might be missing some, if for example they are handled through pin
fixups, or other fixup mechanisms.

I don't have the experience needed to know for sure if the cleanup would
be appropriate. So please excuse the lack of follow-up on that.

Signed-off-by: Samuel Dionne-Riel <samuel@...nne-riel.com>
---
 sound/hda/codecs/realtek/alc269.c | 7 +++++++
 1 file changed, 7 insertions(+)

diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index cafa48b5aceb5..5d38e371a6836 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -3805,6 +3805,7 @@ enum {
 	ALC245_FIXUP_HP_TAS2781_I2C_MUTE_LED,
 	ALC288_FIXUP_SURFACE_SWAP_DACS,
 	ALC236_FIXUP_HP_MUTE_LED_MICMUTE_GPIO,
+	ALC245_FIXUP_BASS_HP_DAC,
 };

 /* A special fixup for Lenovo C940 and Yoga Duet 7;
@@ -6295,6 +6296,11 @@ static const struct hda_fixup alc269_fixups[] = {
 		.type = HDA_FIXUP_FUNC,
 		.v.func = alc288_fixup_surface_swap_dacs,
 	},
+	[ALC245_FIXUP_BASS_HP_DAC] = {
+		.type = HDA_FIXUP_FUNC,
+		/* Borrow the DAC routing selected for those Thinkpads */
+		.v.func = alc285_fixup_thinkpad_x1_gen7,
+	},
 };

 static const struct hda_quirk alc269_fixup_tbl[] = {
@@ -7558,6 +7564,7 @@ static const struct hda_model_fixup alc269_fixup_models[] = {
 	{.id = ALC285_FIXUP_HP_GPIO_AMP_INIT, .name = "alc285-hp-amp-init"},
 	{.id = ALC236_FIXUP_LENOVO_INV_DMIC, .name = "alc236-fixup-lenovo-inv-mic"},
 	{.id = ALC2XX_FIXUP_HEADSET_MIC, .name = "alc2xx-fixup-headset-mic"},
+	{.id = ALC245_FIXUP_BASS_HP_DAC, .name = "alc245-fixup-bass-hp-dac"},
 	{}
 };
 #define ALC225_STANDARD_PINS \
-- 
2.51.0