linux-kernel - Re: [PATCH v6 1/3] input: trackpoint - Enable doubletap by default on capable devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CABxCQKtW5hnTdo7eojMCDyN_bFK3E9MSmacTA=sD+xLYVF279g@mail.gmail.com>
Date: Mon, 2 Feb 2026 12:56:56 +0900
From: Vishnu Sankar <vishnuocv@...il.com>
To: Dmitry Torokhov <dmitry.torokhov@...il.com>
Cc: mpearson-lenovo@...ebb.ca, hmh@....eng.br, hansg@...nel.org, 
	corbet@....net, derekjohn.clark@...il.com, ilpo.jarvinen@...ux.intel.com, 
	linux-input@...r.kernel.org, linux-kernel@...r.kernel.org, 
	ibm-acpi-devel@...ts.sourceforge.net, linux-doc@...r.kernel.org, 
	platform-driver-x86@...r.kernel.org, vsankar@...ovo.com
Subject: Re: [PATCH v6 1/3] input: trackpoint - Enable doubletap by default on
 capable devices

Hi Dmitry,

Thank you for the comments.

On Sun, Feb 1, 2026 at 5:10 PM Dmitry Torokhov
<dmitry.torokhov@...il.com> wrote:
>
> Hi Vishnu,
>
> On Tue, Jan 27, 2026 at 07:39:05PM +0900, Vishnu Sankar wrote:
> > @@ -470,6 +509,14 @@ int trackpoint_detect(struct psmouse *psmouse, bool set_properties)
> >                    psmouse->vendor, firmware_id,
> >                    (button_info & 0xf0) >> 4, button_info & 0x0f);
> >
> > +     /* Enable doubletap by default on capable devices */
>
> This is obvious from the code, please drop the comment.
Understood.
Will remove this in v7.
>
>
> > +     if (trackpoint_is_dt_capable(ps2dev->serio->firmware_id)) {
> > +             if (trackpoint_write(ps2dev, TP_DOUBLETAP, TP_DOUBLETAP_ENABLE))
> > +                     psmouse_warn(psmouse, "Failed to enable doubletap: %d\n", error);
> > +             else
> > +                     psmouse_info(psmouse, "Doubletap enabled by default!\n");
>
> Drop psmouse_info(), no need to make the driver too noisy.
Understood.
I will be removing his log as well.
>
> Otherwise:
>
>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@...il.com>
Thank you
>
> --
> Dmitry



-- 

Regards,

      Vishnu Sankar
     +817015150407 (Japan)