linux-kernel - Re: [PATCH v2] staging: axis-fifo: fix sleep while holding mutex

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2026020353-ended-graffiti-25d4@gregkh>
Date: Tue, 3 Feb 2026 13:02:20 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Baran Arda <baran9arda@...il.com>
Cc: ovidiu.panait.oss@...il.com, gshahrouzi@...il.com,
	linux-staging@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] staging: axis-fifo: fix sleep while holding mutex

On Tue, Feb 03, 2026 at 02:48:58PM +0300, Baran Arda wrote:
> The driver calls wait_event_interruptible_timeout() while holding a mutex. This can lead to a deadlock or poor performance as the mutex is held while the process is sleeping, preventing other processes from accessing the device. This patch moves the wait_event call outside of the mutex lock in both read and write operations.

What kind of tool was used to "find and fix" this "issue"?

And how was this tested?

And are you _sure_ it is correct?  (hint, I think you just broke the
driver's logic, please look closely at your patch...)

And what caused you to want to make this change to this driver?  Do you
have access to this hardware?

thanks,

greg k-h