linux-kernel - Re: [PATCH v10 4/4] irqchip/irq-loongarch-ir:Add Redirect irqchip support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <675fc46a-d44e-34e4-b747-4585819a3aa9@loongson.cn>
Date: Tue, 3 Feb 2026 09:33:58 +0800
From: Tianyang Zhang <zhangtianyang@...ngson.cn>
To: Thomas Gleixner <tglx@...utronix.de>, chenhuacai@...nel.org,
 kernel@...0n.name, corbet@....net, alexs@...nel.org, si.yanteng@...ux.dev,
 jiaxun.yang@...goat.com, maobibo@...ngson.cn
Cc: loongarch@...ts.linux.dev, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, Liupu Wang <wangliupu@...ngson.cn>
Subject: Re: [PATCH v10 4/4] irqchip/irq-loongarch-ir:Add Redirect irqchip
 support

Hi, Thomas

在 2026/2/2 下午6:07, Thomas Gleixner 写道:
> On Mon, Feb 02 2026 at 17:10, Tianyang Zhang wrote:
>> +static inline void redirect_write_reg64(u32 node, u64 val, u32 reg)
>> +{
>> +	return writeq(val, REDIRECT_REG(reg, node));
> 
> Again: What is this return for?
it is meaningless, and the return statement here will be removed later.
> 
>> +static int redirect_table_init(struct irde_desc *irde)
>> +{
>> +	struct redirect_table *ird_table = &irde->ird_table;
>> +	unsigned long *bitmap;
>> +	struct folio *folio;
>> +	int node = irde->node;
> 
> It seems to be really hard to do a length based sort.
> 
> Oh well...
> 
'''
struct redirect_table *ird_table = &irde->ird_table;
unsigned long *bitmap;
struct folio *folio;
int node;

node = irde->node
''''
Maybe this look better, I will try my best......

Thanks
Tianyang