linux-kernel - Re: [PATCH v4 04/13] soc: qcom: geni-se: Handle core clk in geni_se_clks_off() and geni_se_clks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <540cbb53-1028-4f17-ab83-5ac4cabe3421@oss.qualcomm.com>
Date: Tue, 3 Feb 2026 13:14:43 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Praveen Talari <praveen.talari@....qualcomm.com>,
        Andi Shyti <andi.shyti@...nel.org>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>,
        Mukesh Kumar Savaliya <mukesh.savaliya@....qualcomm.com>,
        Viken Dadhaniya <viken.dadhaniya@....qualcomm.com>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad Dybcio <konradybcio@...nel.org>, linux-arm-msm@...r.kernel.org,
        linux-i2c@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org, bjorn.andersson@....qualcomm.com,
        dmitry.baryshkov@....qualcomm.com
Cc: prasad.sodagudi@....qualcomm.com, quic_vtanuku@...cinc.com,
        aniket.randive@....qualcomm.com, chandana.chiluveru@....qualcomm.com,
        jyothi.seerapu@....qualcomm.com
Subject: Re: [PATCH v4 04/13] soc: qcom: geni-se: Handle core clk in
 geni_se_clks_off() and geni_se_clks_on()

On 2/2/26 7:09 PM, Praveen Talari wrote:
> Currently, core clk is handled individually in protocol drivers like
> the I2C driver. Move this clock management to the common clock APIs
> (geni_se_clks_on/off) that are already present in the common GENI SE
> driver to maintain consistency across all protocol drivers.
> 
> Core clk is now properly managed alongside the other clocks (se->clk
> and wrapper clocks) in the fundamental clock control functions,
> eliminating the need for individual protocol drivers to handle this
> clock separately.
> 
> Signed-off-by: Praveen Talari <praveen.talari@....qualcomm.com>
> ---

It may not be obvious from the context, but this core_clk ptr is left
uninitialized (because it'd only be assigned with geni_se_resources_init()
introduced in the previous patch, which is not called at this point)
so everything works out

Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>

Konrad