[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAKYAXd-3c=4MLsdwuCnit6NKX49QzfShwwitj54M5MnMj=EWgQ@mail.gmail.com>
Date: Tue, 3 Feb 2026 22:01:55 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: Christoph Hellwig <hch@....de>
Cc: viro@...iv.linux.org.uk, brauner@...nel.org, tytso@....edu,
willy@...radead.org, jack@...e.cz, djwong@...nel.org, josef@...icpanda.com,
sandeen@...deen.net, rgoldwyn@...e.com, xiang@...nel.org, dsterba@...e.com,
pali@...nel.org, ebiggers@...nel.org, neil@...wn.name, amir73il@...il.com,
linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
iamjoonsoo.kim@....com, cheol.lee@....com, jay.sim@....com, gunho.lee@....com
Subject: Re: [PATCH v6 02/16] Documentation: filesystems: update NTFS driver documentation
On Tue, Feb 3, 2026 at 2:44 PM Christoph Hellwig <hch@....de> wrote:
>
> On Tue, Feb 03, 2026 at 07:01:48AM +0900, Namjae Jeon wrote:
> > Update the NTFS driver documentation (Documentation/filesystems/ntfs.rst)
> > to reflect the current implementation state after switching to iomap and
> > folio instead buffer-head.
> >
> > Changes include:
>
> "Changes include" doesn't really add much value, and feels like AI
> slop.
>
> I'd rewrite the message as:
>
> Update the NTFS driver documentation to reflect the update implementation.
> Remove outdated sections (web site, old features list, known bugs,
> volume/stripe sets with MD/DM driver, limitations of old driver), add a
> concise overview of current driver features and long-term maintenance
> focus, add a utilities support section pointing to ntfsprogs-plus project
> and update mount options list with current supported options.
Okay, I will use this in the next version.
>
> I'd probably also move this last in the series.
Okay.
>
> > +nls=name Deprecated option. Still supported but please use
> > + iocharset=name in the future.
>
> A lot of these mount options sections starts the first line with tab
> indentation and then continue with spaces only. Please stick to one
> of them.
Okay, I will update it in the next version.
>
> Otherwise looks good:
>
> Reviewed-by: Christoph Hellwig <hch@....de>
Thanks for your review!
Powered by blists - more mailing lists