linux-kernel - [PATCH] soc: microchip: mpfs: Fix a memory leak in mpfs_sys_controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20260203-mpfs-v1-1-666b8704f8f7@gmail.com>
Date: Tue, 03 Feb 2026 21:03:52 +0800
From: Felix Gu <ustc.gu@...il.com>
To: Conor Dooley <conor.dooley@...rochip.com>, 
 Daire McNamara <daire.mcnamara@...rochip.com>
Cc: linux-riscv@...ts.infradead.org, linux-kernel@...r.kernel.org, 
 Felix Gu <ustc.gu@...il.com>
Subject: [PATCH] soc: microchip: mpfs: Fix a memory leak in
 mpfs_sys_controller_probe()

In mpfs_sys_controller_probe(), when of_get_mtd_device_by_node() fails,
the previously allocated sys_controller was leaked.

Add kfree() to fix this.

Fixes: 742aa6c563d2 ("soc: microchip: mpfs: enable access to the system controller's flash")
Signed-off-by: Felix Gu <ustc.gu@...il.com>
---
 drivers/soc/microchip/mpfs-sys-controller.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/drivers/soc/microchip/mpfs-sys-controller.c b/drivers/soc/microchip/mpfs-sys-controller.c
index 30bc45d17d34..a7401cb79e97 100644
--- a/drivers/soc/microchip/mpfs-sys-controller.c
+++ b/drivers/soc/microchip/mpfs-sys-controller.c
@@ -142,8 +142,11 @@ static int mpfs_sys_controller_probe(struct platform_device *pdev)
 
 	sys_controller->flash = of_get_mtd_device_by_node(np);
 	of_node_put(np);
-	if (IS_ERR(sys_controller->flash))
-		return dev_err_probe(dev, PTR_ERR(sys_controller->flash), "Failed to get flash\n");
+	if (IS_ERR(sys_controller->flash)) {
+		ret = dev_err_probe(dev, PTR_ERR(sys_controller->flash), "Failed to get flash\n");
+		kfree(sys_controller);
+		return ret;
+	}
 
 no_flash:
 	sys_controller->client.dev = dev;

---
base-commit: 193579fe01389bc21aff0051d13f24e8ea95b47d
change-id: 20260203-mpfs-272dd46bef90

Best regards,
-- 
Felix Gu <ustc.gu@...il.com>