linux-kernel - Re: [PATCH 08/10] ARM: dts: imx7ulp: remove #clock-cells from clock-controller@...10000

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aYFU5w1LpxoUiQH/@shlinux89>
Date: Tue, 3 Feb 2026 09:52:39 +0800
From: Peng Fan <peng.fan@....nxp.com>
To: Frank Li <Frank.Li@....com>
Cc: Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Russell King <linux@...linux.org.uk>, devicetree@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 08/10] ARM: dts: imx7ulp: remove #clock-cells from
 clock-controller@...10000

On Mon, Feb 02, 2026 at 02:43:25PM -0500, Frank Li wrote:
>According to the fsl,imx7ulp-pm.yaml binding, clock-controller@...10000 is
>not a clock provider. Remove the #clock-cells property to fix the following
>CHECK_DTBS warning:
>  clock-controller@...10000 (fsl,imx7ulp-smc1): '#clock-cells' does not match any of the regexes: '^pinctrl-[0-9]+$'
>
>Signed-off-by: Frank Li <Frank.Li@....com>
>---
> arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
>index 880b9a4f32b0846a773dbf9ad30715c84ac2fda6..6d8853d36d930aabb98fb57f49d6153ca6597561 100644
>--- a/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
>+++ b/arch/arm/boot/dts/nxp/imx/imx7ulp.dtsi
>@@ -291,7 +291,6 @@ pcc2: clock-controller@...f0000 {
> 		smc1: clock-controller@...10000 {
> 			compatible = "fsl,imx7ulp-smc1";
> 			reg = <0x40410000 0x1000>;
>-			#clock-cells = <1>;

Need to fix binding, this is a clock controller and needs #clock-cells to work
properly.

There is a driver for this compatible:
drivers/clk/imx/clk-imx7ulp.c

Regards,
Peng

> 			clocks = <&scg1 IMX7ULP_CLK_CORE_DIV>,
> 				 <&scg1 IMX7ULP_CLK_HSRUN_CORE_DIV>;
> 			clock-names = "divcore", "hsrun_divcore";
>
>-- 
>2.34.1
>