linux-kernel - Re: [PATCH] nfs: nfs4proc: Convert comma to semicolon

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d4461ad8bdd78b0d0d4a5dd4b857053602e4175f.camel@kernel.org>
Date: Tue, 03 Feb 2026 08:32:06 -0500
From: Jeff Layton <jlayton@...nel.org>
To: Chen Ni <nichen@...as.ac.cn>, trondmy@...nel.org, anna@...nel.org
Cc: linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] nfs: nfs4proc: Convert comma to semicolon

On Tue, 2026-02-03 at 09:09 +0800, Chen Ni wrote:
> Replace comma between expressions with semicolons.
> 
> Using a ',' in place of a ';' can have unintended side effects.
> Although that is not the case here, it is seems best to use ';'
> unless ',' is intended.
> 
> Found by inspection.
> No functional change intended.
> Compile tested only.
> 
> Signed-off-by: Chen Ni <nichen@...as.ac.cn>
> ---
>  fs/nfs/nfs4proc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfs/nfs4proc.c b/fs/nfs/nfs4proc.c
> index 7c9cf0983366..dacd330fc623 100644
> --- a/fs/nfs/nfs4proc.c
> +++ b/fs/nfs/nfs4proc.c
> @@ -5016,7 +5016,7 @@ static void nfs4_proc_rename_setup(struct rpc_message *msg,
>  	if (same_parent)
>  		nfs_request_directory_delegation(same_parent);
>  	msg->rpc_proc = &nfs4_procedures[NFSPROC4_CLNT_RENAME];
> -	res->server = server,
> +	res->server = server;
>  	nfs4_init_sequence(server->nfs_client, &arg->seq_args,
>  			   &res->seq_res, 1, 0);
>  }

Almost certainly a typo.

Reviewed-by: Jeff Layton <jlayton@...nel.org>