linux-kernel - Re: [PATCH v6 11/16] ntfs: update runlist handling and cluster allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKYAXd-Kpyi_2CVWZoKGTMiMLPwZ7iye-H+A50S6N=bzYyj64Q@mail.gmail.com>
Date: Tue, 3 Feb 2026 23:22:18 +0900
From: Namjae Jeon <linkinjeon@...nel.org>
To: Christoph Hellwig <hch@....de>
Cc: viro@...iv.linux.org.uk, brauner@...nel.org, tytso@....edu, 
	willy@...radead.org, jack@...e.cz, djwong@...nel.org, josef@...icpanda.com, 
	sandeen@...deen.net, rgoldwyn@...e.com, xiang@...nel.org, dsterba@...e.com, 
	pali@...nel.org, ebiggers@...nel.org, neil@...wn.name, amir73il@...il.com, 
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org, 
	iamjoonsoo.kim@....com, cheol.lee@....com, jay.sim@....com, gunho.lee@....com, 
	Hyunchul Lee <hyc.lee@...il.com>
Subject: Re: [PATCH v6 11/16] ntfs: update runlist handling and cluster allocator

On Tue, Feb 3, 2026 at 3:39 PM Christoph Hellwig <hch@....de> wrote:
>
> Suggested commit message:
>
> Updates runlist handling and cluster allocation to support
> contiguous allocations and filesystem trimming.
>
> Improve the runlist API to handle allocation failures and introduces
> discard support.
Okay, I will use it.
>
> > +             if (is_dealloc == true)
> > +                     ntfs_release_dirty_clusters(vol, rl->length);
> >               up_write(&vol->lcnbmp_lock);
> > +             memalloc_nofs_restore(memalloc_flags);
> >               ntfs_debug("Done.");
> > +             return rl == NULL ? ERR_PTR(-EIO) : rl;
>
> In general you want the memalloc_nofs_restore to be after goto
> labels in a single place, as otherwise debugging is really hard.
> In doubt a separate wrapper doing it my be even better.
Okay, I will change it as you pointed out.
Thanks for your review!
>
>