linux-kernel - Re: [PATCH v2] docs: maintainer-pgp-guide.rst: updated kernel.org link

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20260203-spicy-terrestrial-jaguarundi-701efd@lemur>
Date: Tue, 3 Feb 2026 09:48:22 -0500
From: Konstantin Ryabitsev <konstantin@...uxfoundation.org>
To: Amitabh Srivastava <amitabh@...devlab.com>
Cc: corbet@....net, workflows@...r.kernel.org, linux-doc@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2] docs: maintainer-pgp-guide.rst: updated kernel.org
 link

On Tue, Feb 03, 2026 at 10:29:48AM +0530, Amitabh Srivastava wrote:
> docs: process: maintainer-pgp-guide.rst: updated the http link for

I missed this the last time, but you don't need to duplicate the "docs:
process:..." line here.

> 'add the kernel.org UID to your key'. Added SPDX-License-Identifier
> to fix checkpatch.pl warning. Tested kernel using qemu-system-aarch64

You don't need to mention how you tested it (great that you did, but it
doesn't need to be in the commit).

> with busybox inside a multipass ubuntu VM on macos.

I suggest that your submission should look like this:

    Subject: docs: process: maintainer-pgp-guide: update kernel.org docs link

    Update http link to the documentation about how to add a kernel.org UID to
    the maintainer's key. Add missing SPDX-License-Identifier to fix a
    checkpatch warning.

    Signed-off-by: ...

This has the following improvements:

- removes duplicate info that is already in the subject
- uses imperative mood that is required for commits (update vs updated)
  see: https://docs.kernel.org/process/submitting-patches.html#describe-your-changes

> Signed-off-by: Amitabh Srivastava <amitabh@...devlab.com>
> Reviewed-by: Konstantin Ryabitsev <konstantin@...uxfoundation.org>

You shouldn't do this -- I didn't actually reply with  a "Reviewed-by"
trailer. These trailers are given by the reviewer to indicate "I have reviewed
this and didn't find any problems with the patch. You should only add trailers
that you have actually received from reviewers.

Please send a v3 with these fixes and that should earn you a "Reviewed-by."

Best regards,
-- 
KR