linux-kernel - Re: [PATCH RESEND net v3 0/3] disable interrupts and ensure dbell updation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260202180352.513e6eb1@kernel.org>
Date: Mon, 2 Feb 2026 18:03:52 -0800
From: Jakub Kicinski <kuba@...nel.org>
To: Vimlesh Kumar <vimleshk@...vell.com>
Cc: <netdev@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
 <sedara@...vell.com>, <srasheed@...vell.com>, <hgani@...vell.com>
Subject: Re: [PATCH RESEND net v3 0/3] disable interrupts and ensure dbell
 updation

On Fri, 30 Jan 2026 14:15:44 +0000 Vimlesh Kumar wrote:
> Disable per ring interrupts when netdev goes down and ensure dbell BADDR
> updation for both PFs and VFs by adding wait and check for updated value.
> 
> Resending based on discussion with reviewer. 

Looking more closely at this I think the issue Simon flagged is real.
The caller cleans up only the rings for which the init succeeded:

int octep_setup_oqs(struct octep_device *oct)
{
	int i, retval = 0;

	oct->num_oqs = 0;
	for (i = 0; i < CFG_GET_PORTS_ACTIVE_IO_RINGS(oct->conf); i++) {
		retval = octep_setup_oq(oct, i);
		if (retval) {
			dev_err(&oct->pdev->dev,
				"Failed to setup OQ(RxQ)-%d.\n", i);
			goto oq_setup_err;
		}
		dev_dbg(&oct->pdev->dev, "Successfully setup OQ(RxQ)-%d.\n", i);
	}

	return 0;

oq_setup_err:
	while (i) {
		i--;      
		octep_free_oq(oct->oq[i]);
	}
	return -1;