[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20260203101707.52965eb0@gandalf.local.home>
Date: Tue, 3 Feb 2026 10:17:07 -0500
From: Steven Rostedt <rostedt@...dmis.org>
To: Donglin Peng <dolinux.peng@...il.com>
Cc: andrii.nakryiko@...il.com, ast@...nel.org, mhiramat@...nel.org,
linux-kernel@...r.kernel.org, Donglin Peng <pengdonglin@...omi.com>,
linux-trace-kernel@...r.kernel.org, bpf <bpf@...r.kernel.org>, Eduard
Zingerman <eddyz87@...il.com>
Subject: Re: [PATCH 2/2] tracing: resolve enum names for function arguments
via BTF
On Tue, 3 Feb 2026 21:50:47 +0800
Donglin Peng <dolinux.peng@...il.com> wrote:
> Testing revealed that sorting within resolve_btfids introduces issues with
> btf__dedup. Therefore, I plan to move the sorting logic directly into
> btf__add_enum_value and btf__add_enum64_value in libbpf, which are
> invoked by pahole. However, it means that we need a newer pahole
> version.
Sorting isn't a requirement just something I wanted to bring up. If it's
too complex and doesn't achieve much benefit then let's not do it.
My worry is because "cat trace" takes quite a long time just reading the
BTF arguments. I'm worried it will just get worse with enums as well.
I have trace-cmd reading BTF now (just haven't officially released it) and
doing an extract and reading the trace.dat file is much faster than reading
the trace file with arguments. I'll need to implement the enum logic too in
libtraceevent.
-- Steve
Powered by blists - more mailing lists