linux-kernel - Re: [PATCH v2 next 1/5] iio: sca3000: cache SPI device ID in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <eeab5c00-381b-4ee5-bc4a-efc8bd59bb49@baylibre.com>
Date: Tue, 3 Feb 2026 09:26:32 -0600
From: David Lechner <dlechner@...libre.com>
To: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>,
 Jonathan Cameron <jic23@...nel.org>, Nuno Sá
 <nuno.sa@...log.com>, Andy Shevchenko <andy@...nel.org>,
 Antoniu Miclaus <antoniu.miclaus@...log.com>,
 Andrew Ijano <andrew.ijano@...il.com>, linux-iio@...r.kernel.org,
 linux-kernel@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, error27@...il.com,
 andriy.shevchenko@...el.com
Subject: Re: [PATCH v2 next 1/5] iio: sca3000: cache SPI device ID in probe

On 2/3/26 4:24 AM, Harshit Mogalapalli wrote:
> Hi David,
> 
> On 03/02/26 04:31, David Lechner wrote:
>> On 2/2/26 1:40 PM, Harshit Mogalapalli wrote:
>>> Store the spi_device_id at probe entry and reuse it for the name and
>>> chip info instead of calling spi_get_device_id() repeatedly.
>>
>> Even better would be to replace spi_get_device_id() with
>> pi_get_device_match_data() and turn sca3000_spi_chip_info_tbl[]
>> into individual structs that are used directly as the match
>> data pointers.
>>
> 
> Thanks for the review.
> 
> Jonathan also suggested this on v1, but thought of doing this item separate to this patch series(as its a functional change) , would you mind if I do it in a separate patch after this series ?

I'm not sure why it would be considered a functional change. If you want to
save it for a separate series, that is fine. If we do that though, there
is probably not much point in cleaning up spi_get_device_id() first since
it will all be replaced anyway.