linux-kernel - Re: [PATCH v7 2/7] mux: Add helper functions for getting optional and selected mux-state

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6f23c76f-9ced-4675-b262-ffa8dbaf6b33@solid-run.com>
Date: Tue, 3 Feb 2026 15:31:07 +0000
From: Josua Mayer <josua@...id-run.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Marc Kleine-Budde <mkl@...gutronix.de>, Vincent Mailhol
	<mailhol@...nel.org>, Vinod Koul <vkoul@...nel.org>, Neil Armstrong
	<neil.armstrong@...aro.org>, Peter Rosin <peda@...ntia.se>, Aaro Koskinen
	<aaro.koskinen@....fi>, Andreas Kemnade <andreas@...nade.info>, Kevin Hilman
	<khilman@...libre.com>, Roger Quadros <rogerq@...nel.org>, Tony Lindgren
	<tony@...mide.com>, Janusz Krzysztofik <jmkrzyszt@...il.com>, Vignesh R
	<vigneshr@...com>, Andi Shyti <andi.shyti@...nel.org>, Ulf Hansson
	<ulf.hansson@...aro.org>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski
	<krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Geert Uytterhoeven
	<geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, Wolfram Sang
	<wsa+renesas@...g-engineering.com>, Yazan Shhady
	<yazan.shhady@...id-run.com>, Jon Nettleton <jon@...id-run.com>, Mikhail
 Anikin <mikhail.anikin@...id-run.com>, "linux-can@...r.kernel.org"
	<linux-can@...r.kernel.org>, "linux-phy@...ts.infradead.org"
	<linux-phy@...ts.infradead.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-omap@...r.kernel.org"
	<linux-omap@...r.kernel.org>, "linux-i2c@...r.kernel.org"
	<linux-i2c@...r.kernel.org>, "linux-mmc@...r.kernel.org"
	<linux-mmc@...r.kernel.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-renesas-soc@...r.kernel.org"
	<linux-renesas-soc@...r.kernel.org>
Subject: Re: [PATCH v7 2/7] mux: Add helper functions for getting optional and
 selected mux-state

On 03/02/2026 17:05, Dan Carpenter wrote:
> Sorry about that, I just looked at the implementation in linux-next and
> didn't read the code from the patch too closely.
:)
>
> On Wed, Jan 28, 2026 at 04:46:10PM +0200, Josua Mayer wrote:
>> +/**
>> + * mux_control_get_optional() - Get the optional mux-control for a device.
>> + * @dev: The device that needs a mux-control.
>> + * @mux_name: The name identifying the mux-control.
>> + *
>> + * Return: A pointer to the mux-control, an ERR_PTR with a negative errno.
> I wish the documentation for these "optional" said it could return NULL.
Same. I fixed that for v8 on most functions, but missed one .... .
>
>> + */
>> +struct mux_control *mux_control_get_optional(struct device *dev, const char *mux_name)
>> +{
>> +	return mux_get(dev, mux_name, NULL, true);
>> +}
>> +EXPORT_SYMBOL_GPL(mux_control_get_optional);
>> +