linux-kernel - Re: [PATCH v6 3/8] iio: test: add kunit test for fixed-point parsing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYIWg9874VmIdJnA@smile.fi.intel.com>
Date: Tue, 3 Feb 2026 17:38:43 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: rodrigo.alencar@...log.com
Cc: linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Andy Shevchenko <andy@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jonathan Corbet <corbet@....net>
Subject: Re: [PATCH v6 3/8] iio: test: add kunit test for fixed-point parsing

On Fri, Jan 30, 2026 at 10:06:44AM +0000, Rodrigo Alencar via B4 Relay wrote:

> Add kunit test cases that aims to verify expected behavior for
> iio_str_to_fixpoint() and iio_str_to_fixpoint64().
> To run the test, create a .kunitconfig file with:
> 
> CONFIG_KUNIT=y
> CONFIG_IIO=y
> CONFIG_IIO_FIXPOINT_PARSE_KUNIT_TEST=y
> 
> and run the command:
> ./tools/testing/kunit/kunit.py run --kunitconfig=.kunitconfig

Thanks for the test cases!
There are some nit-picks, otherwise
Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>

...

> +#include <kunit/test.h>

+ errno.h // -ERANGE

> +#include <linux/iio/iio.h>

+ limits.h // S32_MIN

> +#include <linux/math.h>

+ types.h // s32

...

> +static struct kunit_suite iio_fixpoint_parse_test_suite = {
> +	.name = "iio-fixpoint-parse",
> +	.test_cases = iio_fixpoint_parse_test_cases,
> +};

> +

Unneeded blank line.

> +kunit_test_suite(iio_fixpoint_parse_test_suite);

-- 
With Best Regards,
Andy Shevchenko