linux-kernel - Re: [PATCH v3 next 2/6] iio: sca3000: reuse device pointer for devm helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c7da67a1-2a88-443f-b3c8-4f13f34fbba3@oracle.com>
Date: Tue, 3 Feb 2026 21:29:02 +0530
From: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
        David Lechner
 <dlechner@...libre.com>,
        Nuno Sá <nuno.sa@...log.com>,
        Andy Shevchenko <andy@...nel.org>,
        Antoniu Miclaus <antoniu.miclaus@...log.com>,
        Andrew Ijano <andrew.ijano@...il.com>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
        error27@...il.com
Subject: Re: [PATCH v3 next 2/6] iio: sca3000: reuse device pointer for devm
 helpers

On 03/02/26 20:47, Andy Shevchenko wrote:
> On Tue, Feb 03, 2026 at 04:20:46AM -0800, Harshit Mogalapalli wrote:
>> Cache struct device *dev and feed it to the devm helpers to simplify
>> the probe function. No functional changes.
> 
> With or without below being addressed,
> Reviewed-by: Andy Shevchenko <andriy.shevchenko@...el.com>
> 
> ...
> 
>> -	ret = devm_iio_kfifo_buffer_setup(&spi->dev, indio_dev,
>> +	ret = devm_iio_kfifo_buffer_setup(dev, indio_dev,
>>   					  &sca3000_ring_setup_ops);
> 
> Now make it a single line, it's just 83 characters.
> 

Sure, will do. I thought the wrap limit is 80, but there are other 
instances in this file where the columns exceeded 80. Will address this 
in my next version.

Thanks!

Regards,
Harshit



>>   	if (ret)
>