[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <DG5GBHGZV86X.2XKAU6WLWCL7Z@garyguo.net>
Date: Tue, 03 Feb 2026 16:02:02 +0000
From: "Gary Guo" <gary@...yguo.net>
To: Onur Özkan <work@...rozkan.dev>, "Jkhall81"
<jason.kei.hall@...il.com>
Cc: <dirk.behme@...bosch.com>, <joe@...ches.com>, <ojeda@...nel.org>,
<rust-for-linux@...r.kernel.org>, <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] scripts: checkpatch: warn on Rust panicking methods
On Tue Feb 3, 2026 at 3:49 PM GMT, Onur Özkan wrote:
> On Tue, 3 Feb 2026 08:25:41 -0700
> Jkhall81 <jason.kei.hall@...il.com> wrote:
>
>> Nice, emails sent from gmail get automatically rejected.
>>
>> So, Dirk. To satisfy your concerns the current 10ish line
>> code update is going to slowly, after many more emails
>> written in nano, mutate into a franken-regex-perl beast.
>> checkpatch.pl is already huge. I'm not a fan of this
>> approach.
>
> Me neither. I wonder why we are doing this instead of using the
> unwrap_used and expect_used linting rules from clippy. This would
> catch the problem much earlier than checkpath since many of us build
> the kernel with CLIPPY=1 flag.
Because it's okay to `panic` or use `expect`. checkpatch will just warn you
once when the code is introduced, not continuously in each build.
Best,
Gary
>
> Regards,
> Onur
>
>>
>> We could just not do this. Right now we are trying to
>> get a warning if someone uses rust code that can cause a
>> panic. Software Engineers are smart people. What if they
>> just don't use rust code that causes panics inside core
>> files. Problem solved.
>>
>>
Powered by blists - more mailing lists