linux-kernel - Re: [net-next,v4,7/9] dpll: Add reference count tracking support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <fe7f81a4-281b-473b-8d0b-d04ff042d471@redhat.com>
Date: Tue, 3 Feb 2026 18:08:09 +0100
From: Ivan Vecera <ivecera@...hat.com>
To: Simon Horman <horms@...nel.org>
Cc: richardcochran@...il.com, arkadiusz.kubalewski@...el.com,
 przemyslaw.kitszel@...el.com, aleksandr.loktionov@...el.com,
 andrew+netdev@...n.ch, pabeni@...hat.com, saeedm@...dia.com,
 kuba@...nel.org, tariqt@...dia.com, netdev@...r.kernel.org,
 grzegorz.nitka@...el.com, poros@...hat.com, davem@...emloft.net,
 vadim.fedorenko@...ux.dev, linux-rdma@...r.kernel.org,
 linux-kernel@...r.kernel.org, aleksander.lobakin@...el.com,
 jonathan.lemon@...il.com, jiri@...nulli.us, anthony.l.nguyen@...el.com,
 intel-wired-lan@...ts.osuosl.org, Prathosh.Satish@...rochip.com,
 leon@...nel.org, edumazet@...gle.com, mbloch@...dia.com
Subject: Re: [net-next,v4,7/9] dpll: Add reference count tracking support



On 2/3/26 5:11 PM, Simon Horman wrote:
> This is an AI-generated review of your patch. The human sending this
> email has considered the AI review valid, or at least plausible.
> 
> For local reproduction steps see https://netdev-ai.bots.linux.dev/ai-local.html
> ---
> dpll: Add reference count tracking support
> 
> This commit adds REF_TRACKER infrastructure support to the DPLL subsystem,
> allowing developers to track and debug reference counting leaks for
> dpll_device and dpll_pin objects via debugfs.
> 
>> diff --git a/include/linux/dpll.h b/include/linux/dpll.h
>> --- a/include/linux/dpll.h
>> +++ b/include/linux/dpll.h
> 
> [ ... ]
> 
>> @@ -223,16 +231,17 @@ dpll_netdev_add_pin_handle(struct sk_buff *msg, const struct net_device *dev)
>>   }
>>
>>   static inline struct dpll_pin *
>> -fwnode_dpll_pin_find(struct fwnode_handle *fwnode)
>> +fwnode_dpll_pin_find(struct fwnode_handle *fwnode, dpll_tracker *tracker);
>>   {
>>   	return NULL;
>>   }
> 
> There appears to be a stray semicolon at the end of the function signature
> on the line with the tracker parameter. This would cause a compile error
> when CONFIG_DPLL is disabled since the function body follows what looks
> like a forward declaration.
> 
> Should the semicolon be removed so the stub function compiles correctly?

Definitely. Will fix as I mentioned previously.

Thanks,
Ivan