linux-kernel - Re: [PATCH 2/2] hpet: Add HPET-based NMI watchdog support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1d74c3cc-d125-49cb-af05-43ca7d15f3f8@amazon.com>
Date: Tue, 3 Feb 2026 18:19:16 +0100
From: Alexander Graf <graf@...zon.com>
To: Sasha Levin <sashal@...nel.org>
CC: Thomas Gleixner <tglx@...nel.org>, <x86@...nel.org>,
	<linux-kernel@...r.kernel.org>, <linux-doc@...r.kernel.org>, Clemens Ladisch
	<clemens@...isch.de>, Arnd Bergmann <arnd@...db.de>, Greg Kroah-Hartman
	<gregkh@...uxfoundation.org>, Dave Hansen <dave.hansen@...ux.intel.com>,
	Borislav Petkov <bp@...en8.de>, Ingo Molnar <mingo@...hat.com>, "Jonathan
 Corbet" <corbet@....net>, Paolo Bonzini <pbonzini@...hat.com>, Pasha Tatashin
	<pasha.tatashin@...een.com>, <nh-open-source@...zon.com>, "Nicolas Saenz
 Julienne" <nsaenz@...zon.es>, Hendrik Borghorst <hborghor@...zon.de>, Filippo
 Sironi <sironi@...zon.de>, David Woodhouse <dwmw@...zon.co.uk>,
	Jan Schönherr <jschoenh@...zon.de>,
	<ricardo.neri-calderon@...ux.intel.com>
Subject: Re: [PATCH 2/2] hpet: Add HPET-based NMI watchdog support

On 03.02.26 17:24, Sasha Levin wrote:
> On Tue, Feb 03, 2026 at 01:36:30PM +0100, Alexander Graf wrote:
>>
>> On 03.02.26 11:32, Thomas Gleixner wrote:
>>> On Mon, Feb 02 2026 at 17:48, Alexander Graf wrote:
>>>> (Disclaimer: Some of this code was written with the help of Kiro, 
>>>> an AI
>>>> coding assistant)
>>> You could have sent your change log through AI too so it conforms with
>>> the change log rules ...
>>
>>
>> Maybe we should introduce an AGENTS.md file in Linux that tells the AI
>> tool to do that automatically? These tools usually don't read README
>> files. :)
>>
>> Looks like - similar to the HPET watchdog - that never concluded though:
>>
>> https://lore.kernel.org/lkml/20250813203647.06e49600@gandalf.local.home/
>>
>> Sasha, are you going to resend your @README commit with a single
>> AGENTS.md? FWIW that is pretty much what everything standardized on by
>> now.
>
> Out of curiosity, can you test your coding assistant on a tree with
> https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/Documentation?id=78d979db6cef557c171d6059cbce06c3db89c7ee 
>
> applied on top?
>
> From my previous testing, the coding assistants I tried it with went 
> to the
> README and DTRT. If that's not the case I'm happy to respin the 
> AGENTS.md idea,
> even if it just explicitly points to the README.

Kiro does not seem to read README automatically. I spun up kiro-cli and 
gave it this prompt: "Write "Hello World" before invoking the init 
process. Then create a descriptive git commit for the change.". No 
Assisted-by: tag, so it did not properly read the README.

I tried the same with an AGENTS.md file present that contains "@README" 
and it gave me effectively the same result. Same for a symlink from 
AGENTS.md to README.

I think it just never really jumped to the conclusion that it should 
read further than just the AGENTS.md file and also ingest the rst, 
effectively ignoring the section's instructions. Or maybe it actually 
reads the .rst and ignores its contents? At least it does read it 
according to strace, even without an AGENTS.md file.

Let me file a bug report with Kiro.

Alex

Amazon Web Services Development Center Germany GmbH
Tamara-Danz-Str. 13
10243 Berlin
Geschaeftsfuehrung: Christof Hellmis, Andreas Stieger
Eingetragen am Amtsgericht Charlottenburg unter HRB 257764 B
Sitz: Berlin
Ust-ID: DE 365 538 597