linux-kernel - Re: [PATCH v3 2/2] clk: imx: imx6q: Fix device node reference leak in of_assigned_ldb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aYIxjWYq3OwwmrTO@lizhi-Precision-Tower-5810>
Date: Tue, 3 Feb 2026 12:34:05 -0500
From: Frank Li <Frank.li@....com>
To: Felix Gu <ustc.gu@...il.com>
Cc: Abel Vesa <abelvesa@...nel.org>, Peng Fan <peng.fan@....com>,
	Michael Turquette <mturquette@...libre.com>,
	Stephen Boyd <sboyd@...nel.org>,
	Sascha Hauer <s.hauer@...gutronix.de>,
	Pengutronix Kernel Team <kernel@...gutronix.de>,
	Fabio Estevam <festevam@...il.com>,
	Lucas Stach <l.stach@...gutronix.de>,
	Philipp Zabel <p.zabel@...gutronix.de>,
	Akshay Bhat <akshay.bhat@...esys.com>,
	Ranjani Vaidyanathan <Ranjani.Vaidyanathan@....com>,
	Shawn Guo <shawnguo@...nel.org>, linux-clk@...r.kernel.org,
	imx@...ts.linux.dev, linux-arm-kernel@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3 2/2] clk: imx: imx6q: Fix device node reference leak
 in of_assigned_ldb_sels()

On Tue, Feb 03, 2026 at 10:07:58PM +0800, Felix Gu wrote:
> The function of_assigned_ldb_sels() calls of_parse_phandle_with_args()
> but never calls of_node_put() to release the reference, causing a memory
> leak.
>
> Fix this by adding proper cleanup calls on all exit paths.
>
> Fixes: 5d283b083800 ("clk: imx6: Fix procedure to switch the parent of LDB_DI_CLK")
> Signed-off-by: Felix Gu <ustc.gu@...il.com>
> ---
Reviewed-by: Frank Li <Frank.Li@....com>
>  drivers/clk/imx/clk-imx6q.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/clk/imx/clk-imx6q.c b/drivers/clk/imx/clk-imx6q.c
> index ba696cf34fe3..048e2ddba490 100644
> --- a/drivers/clk/imx/clk-imx6q.c
> +++ b/drivers/clk/imx/clk-imx6q.c
> @@ -188,9 +188,11 @@ static void of_assigned_ldb_sels(struct device_node *node,
>  		}
>  		if (clkspec.np != node || clkspec.args[0] >= IMX6QDL_CLK_END) {
>  			pr_err("ccm: parent clock %d not in ccm\n", index);
> +			of_node_put(clkspec.np);
>  			return;
>  		}
>  		parent = clkspec.args[0];
> +		of_node_put(clkspec.np);
>
>  		rc = of_parse_phandle_with_args(node, "assigned-clocks",
>  				"#clock-cells", index, &clkspec);
> @@ -198,9 +200,11 @@ static void of_assigned_ldb_sels(struct device_node *node,
>  			return;
>  		if (clkspec.np != node || clkspec.args[0] >= IMX6QDL_CLK_END) {
>  			pr_err("ccm: child clock %d not in ccm\n", index);
> +			of_node_put(clkspec.np);
>  			return;
>  		}
>  		child = clkspec.args[0];
> +		of_node_put(clkspec.np);
>
>  		if (child != IMX6QDL_CLK_LDB_DI0_SEL &&
>  		    child != IMX6QDL_CLK_LDB_DI1_SEL)
>
> --
> 2.43.0
>