linux-kernel - Re: [PATCH 1/2] mm/kmemleak: Remove unreachable return statement in scan_should

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYI2grbaboVrhXoj@arm.com>
Date: Tue, 3 Feb 2026 17:55:14 +0000
From: Catalin Marinas <catalin.marinas@....com>
To: Zhongqiu Han <zhongqiu.han@....qualcomm.com>
Cc: akpm@...ux-foundation.org, linux-mm@...ck.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/2] mm/kmemleak: Remove unreachable return statement in
 scan_should_stop()

On Fri, Jan 30, 2026 at 05:37:28PM +0800, Zhongqiu Han wrote:
> Remove unreachable "return 0;" statement as all execution paths return
> before reaching it.
> 
> No functional change.
> 
> Signed-off-by: Zhongqiu Han <zhongqiu.han@....qualcomm.com>
> ---
>  mm/kmemleak.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/mm/kmemleak.c b/mm/kmemleak.c
> index fe33f2edfe07..fb0022f34393 100644
> --- a/mm/kmemleak.c
> +++ b/mm/kmemleak.c
> @@ -1509,10 +1509,8 @@ static int scan_should_stop(void)
>  	 */
>  	if (current->mm)
>  		return signal_pending(current);
> -	else
> -		return kthread_should_stop();
>  
> -	return 0;
> +	return kthread_should_stop();
>  }

Yeah, not sure how I ended up with this.

Acked-by: Catalin Marinas <catalin.marinas@....com>