linux-kernel - Re: [PATCH v9 7/7] i2c: xiic: skip input clock setup on non-OF systems

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <9F7815FA-80D8-4C96-B61F-5CA6CB405F7A@nexthop.ai>
Date: Tue, 3 Feb 2026 10:38:51 -0800
From: Abdurrahman Hussain <abdurrahman@...thop.ai>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Michal Simek <michal.simek@....com>,
 Andi Shyti <andi.shyti@...nel.org>,
 Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 linux-arm-kernel@...ts.infradead.org,
 linux-i2c@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH v9 7/7] i2c: xiic: skip input clock setup on non-OF
 systems



> On Feb 3, 2026, at 7:46 AM, Andy Shevchenko <andriy.shevchenko@...el.com> wrote:
> 
> On Mon, Feb 02, 2026 at 08:37:24PM +0000, Abdurrahman Hussain via B4 Relay wrote:
> 
>> Currently Linux does not implement ACPI ClockInput to describe clock
> 
> ClockInput() resource
> 
>> resources, unlike DT. However the xiic driver is happy if something
>> magically enables the clock before the driver probes, and does not
>> turn it off again. The clock should always be considered optional for
>> ACPI.
> 

I just used the wording provided earlier by Andrew verbatim. But can change
to the following if you insist:

Currently Linux does not implement ACPI ClockInput() resource to describe
clocks, unlike DT. However the xiic driver is happy if something
magically enables the clock before the driver probes, and does not
turn it off again. The clock should always be considered optional for
ACPI.

> ...
> 
>> + if (is_of_node(dev_fwnode(dev))) {
>> + i2c->clk = devm_clk_get_enabled(dev, NULL);
>> + if (IS_ERR(i2c->clk))
>> + return dev_err_probe(&pdev->dev, PTR_ERR(i2c->clk),
> 
> Haven't you seen my previous comments? Why 'pdev’?
> 
Sorry, I missed it. Will fix in V10.

>> + "failed to enable input clock.\n");
>> + }
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
>