linux-kernel - Re: [PATCH v9 4/7] i2c: xiic: cosmetic cleanup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DE565BCD-28D6-4844-BCEE-A1F60DC84662@nexthop.ai>
Date: Tue, 3 Feb 2026 10:59:31 -0800
From: Abdurrahman Hussain <abdurrahman@...thop.ai>
To: Andy Shevchenko <andriy.shevchenko@...el.com>
Cc: Michal Simek <michal.simek@....com>,
 Andi Shyti <andi.shyti@...nel.org>,
 Rob Herring <robh@...nel.org>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>,
 linux-arm-kernel@...ts.infradead.org,
 linux-i2c@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 devicetree@...r.kernel.org
Subject: Re: [PATCH v9 4/7] i2c: xiic: cosmetic cleanup



> On Feb 3, 2026, at 7:42 AM, Andy Shevchenko <andriy.shevchenko@...el.com> wrote:
> 
> On Mon, Feb 02, 2026 at 08:37:21PM +0000, Abdurrahman Hussain via B4 Relay wrote:
> 
>> Re-use dev pointer instead of referencing &pdev->dev everywhere.
> 
> ...
> 
>> - dev_dbg(&pdev->dev, "mmio %08lx irq %d scl clock frequency %d\n",
>> + dev_dbg(dev, "mmio %08lx irq %d scl clock frequency %d\n",
>> (unsigned long)res->start, irq, i2c->i2c_clk);
> 
> No need to do this here as we change the format string afterwards anyway.
> 
> But I leave it up to Andi, I won't prevent this to go in, if he agrees.
> 
> -- 
> With Best Regards,
> Andy Shevchenko
> 
> 

No worries, I can do this in the following patch, since there is going to be
a v 10 anyways.