linux-kernel - Re: [PATCH V1] accel/amdxdna: Fix incorrect error code returned for failed chain command

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1b5b3c24-239d-c177-6fae-bad46d382430@amd.com>
Date: Tue, 3 Feb 2026 11:40:10 -0800
From: Lizhi Hou <lizhi.hou@....com>
To: "Falkowski, Maciej" <maciej.falkowski@...ux.intel.com>,
	<ogabbay@...nel.org>, <quic_jhugo@...cinc.com>,
	<dri-devel@...ts.freedesktop.org>
CC: <linux-kernel@...r.kernel.org>, <max.zhen@....com>,
	<sonal.santan@....com>, <mario.limonciello@....com>
Subject: Re: [PATCH V1] accel/amdxdna: Fix incorrect error code returned for
 failed chain command

Applied to drm-misc-next-fixes.

On 2/3/26 10:52, Falkowski, Maciej wrote:
> Reviewed-by: Maciej Falkowski <maciej.falkowski@...ux.intel.com>
>
> On 2/3/2026 7:40 PM, Lizhi Hou wrote:
>> The driver currently returns an incorrect error code when a chain 
>> command
>> fails. In this case, ERT_CMD_STATE_ERROR is expected to be reported for
>> failed chain commands.
>>
>> Fixes: aac243092b70 ("accel/amdxdna: Add command execution")
>> Signed-off-by: Lizhi Hou <lizhi.hou@....com>
>> ---
>>   drivers/accel/amdxdna/aie2_ctx.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/accel/amdxdna/aie2_ctx.c 
>> b/drivers/accel/amdxdna/aie2_ctx.c
>> index ad5b5cd0bc81..fe8f9783a73c 100644
>> --- a/drivers/accel/amdxdna/aie2_ctx.c
>> +++ b/drivers/accel/amdxdna/aie2_ctx.c
>> @@ -274,7 +274,7 @@ aie2_sched_cmdlist_resp_handler(void *handle, 
>> void __iomem *data, size_t size)
>>           ret = -EINVAL;
>>           goto out;
>>       }
>> -    amdxdna_cmd_set_state(cmd_abo, fail_cmd_status);
>> +    amdxdna_cmd_set_state(cmd_abo, ERT_CMD_STATE_ERROR);
>>         if (amdxdna_cmd_get_op(cmd_abo) == ERT_CMD_CHAIN) {
>>           struct amdxdna_cmd_chain *cc = 
>> amdxdna_cmd_get_payload(cmd_abo, NULL);