linux-kernel - Re: [PATCH v2] audit: Avoid excessive dput/dget in audit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260203195958.GG3183987@ZenIV>
Date: Tue, 3 Feb 2026 19:59:58 +0000
From: Al Viro <viro@...iv.linux.org.uk>
To: Waiman Long <longman@...hat.com>
Cc: Paul Moore <paul@...l-moore.com>, Eric Paris <eparis@...hat.com>,
	Christian Brauner <brauner@...nel.org>,
	linux-kernel@...r.kernel.org, audit@...r.kernel.org,
	Richard Guy Briggs <rgb@...hat.com>,
	Ricardo Robaina <rrobaina@...hat.com>
Subject: Re: [PATCH v2] audit: Avoid excessive dput/dget in audit_context
 setup and reset paths

On Tue, Feb 03, 2026 at 02:44:33PM -0500, Waiman Long wrote:

> +		/*
> +		 * Defer the path_put() call of the old pwd to workqueue as
> +		 * we may be in an atomic context that cannot call path_put()
> +		 * directly because of might_sleep().
> +		 */
> +		pp = kmalloc(sizeof(*pp), GFP_NOFS);

If that really gets called in atomic context, this kmalloc will
in itself be enough to fuck you over, won't it?