linux-kernel - Re: [PATCH v2] PM: sleep: wakeirq: harden dev_pm_clear_wake

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAJZ5v0jGuMrwsuR-8XbmD+WXwdK1V4t9G6VSS7KPveCJ1N2TCA@mail.gmail.com>
Date: Tue, 3 Feb 2026 21:26:36 +0100
From: "Rafael J. Wysocki" <rafael@...nel.org>
To: Markus Elfring <Markus.Elfring@....de>
Cc: Gui-Dong Han <hanguidong02@...il.com>, linux-pm@...r.kernel.org, 
	Danilo Krummrich <dakr@...nel.org>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, 
	Len Brown <lenb@...nel.org>, Pavel Machek <pavel@...nel.org>, 
	"Rafael J. Wysocki" <rafael@...nel.org>, Tony Lindgren <tony@...mide.com>, 
	LKML <linux-kernel@...r.kernel.org>, Jia-Ju Bai <baijiaju1990@...il.com>
Subject: Re: [PATCH v2] PM: sleep: wakeirq: harden dev_pm_clear_wake_irq()
 against races

On Tue, Feb 3, 2026 at 10:16 AM Markus Elfring <Markus.Elfring@....de> wrote:
>
> …
> > +++ b/drivers/base/power/wakeirq.c
> > @@ -83,13 +83,16 @@ EXPORT_SYMBOL_GPL(dev_pm_set_wake_irq);
> >   */
> >  void dev_pm_clear_wake_irq(struct device *dev)
> >  {
> > -     struct wake_irq *wirq = dev->power.wakeirq;
> > +     struct wake_irq *wirq;
> >       unsigned long flags;
> >
> > -     if (!wirq)
> > +     spin_lock_irqsave(&dev->power.lock, flags);
> > +     wirq = dev->power.wakeirq;
> > +     if (!wirq) {
> > +             spin_unlock_irqrestore(&dev->power.lock, flags);
> >               return;
> > +     }
> >
> > -     spin_lock_irqsave(&dev->power.lock, flags);
> >       device_wakeup_detach_irq(dev);
> >       dev->power.wakeirq = NULL;
> >       spin_unlock_irqrestore(&dev->power.lock, flags);
>
> Would it become feasible to apply a scoped_guard() call?
> https://elixir.bootlin.com/linux/v6.19-rc5/source/include/linux/spinlock.h#L585

Yes, it would, but in a separate patch.