linux-kernel - Re: [PATCH v2] audit: Avoid excessive dput/dget in audit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260203215002.GI3183987@ZenIV>
Date: Tue, 3 Feb 2026 21:50:02 +0000
From: Al Viro <viro@...iv.linux.org.uk>
To: Waiman Long <llong@...hat.com>
Cc: Paul Moore <paul@...l-moore.com>, Eric Paris <eparis@...hat.com>,
	Christian Brauner <brauner@...nel.org>,
	linux-kernel@...r.kernel.org, audit@...r.kernel.org,
	Richard Guy Briggs <rgb@...hat.com>,
	Ricardo Robaina <rrobaina@...hat.com>
Subject: Re: [PATCH v2] audit: Avoid excessive dput/dget in audit_context
 setup and reset paths

On Tue, Feb 03, 2026 at 03:32:04PM -0500, Waiman Long wrote:

> That is actually a concern that I have at the back of my mind. I can modify
> the patch to cache only the dentry and do get/put the mount every time which
> is much cheaper as it is a percpu counter.  In that way, a chdir(2) followed
> by a umount(2) shouldn't cause a -EBUSY. Right?

Quite - it will just retain a reference to dentry, with filesystem shutdown
being very unhappy about somebody retaining references to objects on the
filesystem about to be taken out...