linux-kernel - Re: [PATCH 2/2] Input: charlieplex_keypad: add GPIO charlieplex keypad

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <202602040703.1Bu56Htu-lkp@intel.com>
Date: Wed, 4 Feb 2026 07:17:08 +0800
From: kernel test robot <lkp@...el.com>
To: Hugo Villeneuve <hugo@...ovil.com>, hvilleneuve@...onoff.com,
	dmitry.torokhov@...il.com, robh@...nel.org, krzk+dt@...nel.org,
	conor+dt@...nel.org
Cc: oe-kbuild-all@...ts.linux.dev, linux-input@...r.kernel.org,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	hugo@...ovil.com
Subject: Re: [PATCH 2/2] Input: charlieplex_keypad: add GPIO charlieplex
 keypad

Hi Hugo,

kernel test robot noticed the following build warnings:

[auto build test WARNING on ed8a4ef29da3821ee3155d3b1925fa67fc92aae2]

url:    https://github.com/intel-lab-lkp/linux/commits/Hugo-Villeneuve/dt-bindings-input-add-GPIO-charlieplex-keypad/20260204-001338
base:   ed8a4ef29da3821ee3155d3b1925fa67fc92aae2
patch link:    https://lore.kernel.org/r/20260203155023.536103-3-hugo%40hugovil.com
patch subject: [PATCH 2/2] Input: charlieplex_keypad: add GPIO charlieplex keypad
config: parisc-randconfig-r072-20260204 (https://download.01.org/0day-ci/archive/20260204/202602040703.1Bu56Htu-lkp@intel.com/config)
compiler: hppa-linux-gcc (GCC) 8.5.0
smatch version: v0.5.0-8994-gd50c5a4c
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260204/202602040703.1Bu56Htu-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602040703.1Bu56Htu-lkp@intel.com/

All warnings (new ones prefixed by >>):

   drivers/input/keyboard/charlieplex_keypad.c: In function 'charlieplex_keypad_init_gpio':
>> drivers/input/keyboard/charlieplex_keypad.c:120:6: warning: variable 'nkeys' set but not used [-Wunused-but-set-variable]
     int nkeys;
         ^~~~~


vim +/nkeys +120 drivers/input/keyboard/charlieplex_keypad.c

   115	
   116	static int charlieplex_keypad_init_gpio(struct platform_device *pdev,
   117						struct charlieplex_keypad *keypad)
   118	{
   119		bool active_low;
 > 120		int nkeys;
   121		int i;
   122	
   123		keypad->line_gpios = devm_gpiod_get_array(&pdev->dev, "line", GPIOD_IN);
   124		if (IS_ERR(keypad->line_gpios))
   125			return PTR_ERR(keypad->line_gpios);
   126	
   127		keypad->nlines = keypad->line_gpios->ndescs;
   128	
   129		if (keypad->nlines > MATRIX_MAX_ROWS)
   130			return -EINVAL;
   131	
   132		nkeys = (keypad->nlines * keypad->nlines) - keypad->nlines;
   133	
   134		active_low = device_property_read_bool(&pdev->dev, "gpio-activelow");
   135	
   136		for (i = 0; i < keypad->nlines; i++) {
   137			gpiod_set_consumer_name(keypad->line_gpios->desc[i], "charlieplex_kbd_line");
   138	
   139			if (active_low ^ gpiod_is_active_low(keypad->line_gpios->desc[i]))
   140				gpiod_toggle_active_low(keypad->line_gpios->desc[i]);
   141		}
   142	
   143		return 0;
   144	}
   145	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki