linux-kernel - Re: [PATCH v2] tracing: Fix funcgraph_exit calltime/rettime offset for 32-bit ARM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202602031142.uHVfwxw3-lkp@intel.com>
Date: Tue, 3 Feb 2026 12:06:03 +0800
From: kernel test robot <lkp@...el.com>
To: "jempty.liang" <imntjempty@....com>, rostedt@...dmis.org,
	mhiramat@...nel.org, mark.rutland@....com,
	mathieu.desnoyers@...icios.com
Cc: oe-kbuild-all@...ts.linux.dev, linux-kernel@...r.kernel.org,
	linux-trace-kernel@...r.kernel.org,
	"jempty.liang" <imntjempty@....com>
Subject: Re: [PATCH v2] tracing: Fix funcgraph_exit calltime/rettime offset
 for 32-bit ARM

Hi jempty.liang,

kernel test robot noticed the following build warnings:

[auto build test WARNING on trace/for-next]
[also build test WARNING on linus/master v6.19-rc8 next-20260202]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/jempty-liang/tracing-Fix-funcgraph_exit-calltime-rettime-offset-for-32-bit-ARM/20260202-203926
base:   https://git.kernel.org/pub/scm/linux/kernel/git/trace/linux-trace for-next
patch link:    https://lore.kernel.org/r/20260202123342.2544795-1-imntjempty%40163.com
patch subject: [PATCH v2] tracing: Fix funcgraph_exit calltime/rettime offset for 32-bit ARM
config: x86_64-buildonly-randconfig-004-20260203 (https://download.01.org/0day-ci/archive/20260203/202602031142.uHVfwxw3-lkp@intel.com/config)
compiler: gcc-14 (Debian 14.2.0-19) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260203/202602031142.uHVfwxw3-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202602031142.uHVfwxw3-lkp@intel.com/

All warnings (new ones prefixed by >>):

   kernel/trace/trace_irqsoff.c: In function 'irqsoff_graph_return':
>> kernel/trace/trace_irqsoff.c:224:13: warning: unused variable 'rettime' [-Wunused-variable]
     224 |         u64 rettime;
         |             ^~~~~~~


vim +/rettime +224 kernel/trace/trace_irqsoff.c

62b915f1060996 Jiri Olsa                 2010-04-02  214  
37238abe3cb47b Steven Rostedt (VMware    2024-06-03  215) static void irqsoff_graph_return(struct ftrace_graph_ret *trace,
2ca8c112c9676e Masami Hiramatsu (Google  2024-12-26  216) 				 struct fgraph_ops *gops,
2ca8c112c9676e Masami Hiramatsu (Google  2024-12-26  217) 				 struct ftrace_regs *fregs)
62b915f1060996 Jiri Olsa                 2010-04-02  218  {
62b915f1060996 Jiri Olsa                 2010-04-02  219  	struct trace_array *tr = irqsoff_trace;
62b915f1060996 Jiri Olsa                 2010-04-02  220  	struct trace_array_cpu *data;
62b915f1060996 Jiri Olsa                 2010-04-02  221  	unsigned long flags;
36590c50b2d072 Sebastian Andrzej Siewior 2021-01-25  222  	unsigned int trace_ctx;
a485ea9e3ef31a Steven Rostedt            2025-01-13  223  	u64 *calltime;
66611c04757096 Steven Rostedt            2025-01-21 @224  	u64 rettime;
a485ea9e3ef31a Steven Rostedt            2025-01-13  225  	int size;
62b915f1060996 Jiri Olsa                 2010-04-02  226  
12117f3307b63f Steven Rostedt (VMware    2024-06-03  227) 	ftrace_graph_addr_finish(gops, trace);
5cf99a0f3161bc Steven Rostedt (VMware    2018-11-29  228) 
5e6d2b9cfa3a6e Steven Rostedt            2010-10-05  229  	if (!func_prolog_dec(tr, &data, &flags))
62b915f1060996 Jiri Olsa                 2010-04-02  230  		return;
62b915f1060996 Jiri Olsa                 2010-04-02  231  
77a67833e830fd jempty.liang              2026-02-02  232  	trace->rettime = trace_clock_local();
a485ea9e3ef31a Steven Rostedt            2025-01-13  233  	calltime = fgraph_retrieve_data(gops->idx, &size);
c834a97962c708 Steven Rostedt            2025-10-08  234  	if (calltime) {
77a67833e830fd jempty.liang              2026-02-02  235  		trace->calltime = *calltime;
36590c50b2d072 Sebastian Andrzej Siewior 2021-01-25  236  		trace_ctx = tracing_gen_ctx_flags(flags);
77a67833e830fd jempty.liang              2026-02-02  237  		__trace_graph_return(tr, trace, trace_ctx);
c834a97962c708 Steven Rostedt            2025-10-08  238  	}
90633c34c36d0c Steven Rostedt            2025-05-05  239  	local_dec(&data->disabled);
62b915f1060996 Jiri Olsa                 2010-04-02  240  }
62b915f1060996 Jiri Olsa                 2010-04-02  241  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki