[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20260203053446.68919-1-sj@kernel.org>
Date: Mon, 2 Feb 2026 21:34:45 -0800
From: SeongJae Park <sj@...nel.org>
To: gutierrez.asier@...wei-partners.com
Cc: SeongJae Park <sj@...nel.org>,
artem.kuzin@...wei.com,
stepanov.anatoly@...wei.com,
wangkefeng.wang@...wei.com,
yanquanmin1@...wei.com,
zuoze1@...wei.com,
damon@...ts.linux.dev,
akpm@...ux-foundation.org,
linux-mm@...ck.org,
linux-kernel@...r.kernel.org
Subject: Re: [RFC PATCH v1 4/4] documentation/mm/damon: Documentation for the dynamic_hugepages module
Let's use "Docs/admin-guide/mm/damon:" as the prefix of the commit subject.
On Mon, 2 Feb 2026 14:56:49 +0000 <gutierrez.asier@...wei-partners.com> wrote:
> From: Asier Gutierrez <gutierrez.asier@...wei-partners.com>
>
> Documentation for dynamic_hugepage DAMON module.
>
> Signed-off-by: Asier Gutierrez <gutierrez.asier@...wei-partners.com>
> Co-developed-by: Anatoly Stepanov <stepanov.anatoly@...wei.com>
> ---
> .../mm/damon/dynamic_hugepages.rst (new) | 173 ++++++++++++++++++
> 1 file changed, 173 insertions(+)
>
> diff --git a/Documentation/admin-guide/mm/damon/dynamic_hugepages.rst b/Documentation/admin-guide/mm/damon/dynamic_hugepages.rst
> new file mode 100644
> index 000000000000..a6afb0910661
> --- /dev/null
> +++ b/Documentation/admin-guide/mm/damon/dynamic_hugepages.rst
[...]
> +How It Works?
> +=============
> +
> +DAMON_HOT_HUGEPAGE spawns a new kthread which will monitor the applications in
> +the system. The monitor thread will calculate the moving average of the sum of
> +utimes of all the threads for all the processes. Then, pick the top three and
> +launch a damon process to monitor the hot regions in those tasks.
> +
> +Since we don't know the minaccess number in advance, we set it to 90 initially,
minaccess number -> optimum value of the min_nr_accesses value ?
[...]
> +Example
> +=======
> +Below runtime example commands make DAMON_HOT_HUGEPAGE to find memory regions in
> +the 3 most active tasks. It also asks DAMON_HOT_HUGEPAGE to do nothing if the
> +system's free memory rate is more than 50%, but start the real works if it
> +becomes lower than 40%.
> +
> + # cd /sys/module/damon_dynamic_hotpages/parameters/
> + # echo 10 > quota_ms
> + # echo 1000 > quota_reset_interval_ms
> + # echo 500 > wmarks_high
> + # echo 400 > wmarks_mid
> + # echo 200 > wmarks_low
> + # echo Y > enabled
> \ No newline at end of file
Please generously give a new line ;)
My high line comments including name of the module, the expected use case of
the watermarks also apply above. Same to my comment on the third patch of this
series, I will do more detailed review of this patch again on the next
version, since I presume the high level idea discussion is the main goal of
this series. Correct me if I'm wrong.
Thanks,
SJ
[...]
Powered by blists - more mailing lists