linux-kernel - Re: [PATCH v6 04/16] ntfs: update in-memory, on-disk structures and headers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260203054741.GB16426@lst.de>
Date: Tue, 3 Feb 2026 06:47:41 +0100
From: Christoph Hellwig <hch@....de>
To: Namjae Jeon <linkinjeon@...nel.org>
Cc: viro@...iv.linux.org.uk, brauner@...nel.org, hch@....de, tytso@....edu,
	willy@...radead.org, jack@...e.cz, djwong@...nel.org,
	josef@...icpanda.com, sandeen@...deen.net, rgoldwyn@...e.com,
	xiang@...nel.org, dsterba@...e.com, pali@...nel.org,
	ebiggers@...nel.org, neil@...wn.name, amir73il@...il.com,
	linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
	iamjoonsoo.kim@....com, cheol.lee@....com, jay.sim@....com,
	gunho.lee@....com
Subject: Re: [PATCH v6 04/16] ntfs: update in-memory, on-disk structures
 and headers

On Tue, Feb 03, 2026 at 07:01:50AM +0900, Namjae Jeon wrote:
> This patch updates the NTFS filesystem driver's in-memory and on-disk
> structures.
> 
> Key changes include:
> 
>  - Reorganize the comments in headers for better readability. (Fix the
>    warnings from checkpatch.pl also)
>  - Refactoring of core structures ntfs_inode and ntfs_volume to
>    support new features such as iomap, and others.
>  - Introduction of `iomap` infrastructure (iomap.h) and initial
>    support for reparse points (reparse.h) and EA attribute(ea.h)
>  - Remove unnecessary types.h and endian.h headers.

Key changes include once again does not really add value here, and
a lot of maintainers hate the "This patch" wording.

Suggested alternate version:

Update the NTFS filesystem driver's in-memory and on-disk structures:

  - Introduce the `iomap` infrastructure and initial support for reparse
    points and EA attribute.
  - Refactor the core ntfs_inode and ntfs_volume structures to support
    new features such as iomap.
  - Remove the unnecessary types.h and endian.h headers.
  - Reorganize the comments in headers for better readability, including
    fixing warnings from checkpatch.pl.

Otherwise looks good:

Reviewed-by: Christoph Hellwig <hch@....de>