linux-kernel - Re: [PATCH] pinctrl: meson: amlogic-a4: Fix device node reference leak in bank helpers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD++jLnM+_ot6CyDKYDUKcy5EcEFYbDZD1_0FxHoxF=S8yFyPA@mail.gmail.com>
Date: Tue, 3 Feb 2026 01:29:20 +0100
From: Linus Walleij <linusw@...nel.org>
To: Felix Gu <ustc.gu@...il.com>
Cc: Xianwei Zhao <xianwei.zhao@...ogic.com>, Neil Armstrong <neil.armstrong@...aro.org>, 
	Kevin Hilman <khilman@...libre.com>, Jerome Brunet <jbrunet@...libre.com>, 
	Martin Blumenstingl <martin.blumenstingl@...glemail.com>, linux-amlogic@...ts.infradead.org, 
	linux-gpio@...r.kernel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] pinctrl: meson: amlogic-a4: Fix device node reference
 leak in bank helpers

On Tue, Jan 27, 2026 at 7:23 PM Felix Gu <ustc.gu@...il.com> wrote:

> of_parse_phandle_with_fixed_args() increments the reference count of the
> returned device node, so it must be explicitly released using
> of_node_put() after use.
>
> Fix the reference leak in aml_bank_pins() and aml_bank_number() by
> adding the missing of_node_put() calls.
>
> Fixes: 6e9be3abb78c ("pinctrl: Add driver support for Amlogic SoCs")
> Signed-off-by: Felix Gu <ustc.gu@...il.com>

Patch applied!

Yours,
Linus Walleij