[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <177007894257.4027.5238022262476955140@lazor>
Date: Mon, 02 Feb 2026 17:35:42 -0700
From: Stephen Boyd <sboyd@...nel.org>
To: Marek Vasut <marek.vasut+renesas@...lbox.org>, linux-clk@...r.kernel.org
Cc: Marek Vasut <marek.vasut+renesas@...lbox.org>, stable@...r.kernel.org, Geert Uytterhoeven <geert+renesas@...der.be>, Michael Turquette <mturquette@...libre.com>, linux-kernel@...r.kernel.org, linux-renesas-soc@...r.kernel.org
Subject: Re: [PATCH v3] clk: rs9: Reserve 8 struct clk_hw slots for for 9FGV0841
Quoting Marek Vasut (2026-01-21 16:26:38)
> The 9FGV0841 has 8 outputs and registers 8 struct clk_hw, make sure
> there are 8 slots for those newly registered clk_hw pointers, else
> there is going to be out of bounds write when pointers 4..7 are set
> into struct rs9_driver_data .clk_dif[4..7] field.
>
> Since there are other structure members past this struct clk_hw
> pointer array, writing to .clk_dif[4..7] fields corrupts both
> the struct rs9_driver_data content and data around it, sometimes
> without crashing the kernel. However, the kernel does surely
> crash when the driver is unbound or during suspend.
>
> Fix this, increase the struct clk_hw pointer array size to the
> maximum output count of 9FGV0841, which is the biggest chip that
> is supported by this driver.
>
> Cc: stable@...r.kernel.org
> Fixes: f0e5e1800204 ("clk: rs9: Add support for 9FGV0841")
> Reviewed-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Tested-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Reported-by: Geert Uytterhoeven <geert+renesas@...der.be>
> Closes: https://lore.kernel.org/CAMuHMdVyQpOBT+Ho+mXY07fndFN9bKJdaaWGn91WOFnnYErLyg@mail.gmail.com
> Signed-off-by: Marek Vasut <marek.vasut+renesas@...lbox.org>
> ---
Applied to clk-next
Powered by blists - more mailing lists