linux-kernel - Re: [PATCH v2 3/6] drm/mcde: dsi: mcde_dsi_bind: break when a panel or bridge is found

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAD++jLnbXyCK+iY8M=tMTGvsSq=Gg5mxiqyGAh6NKOyVz5tzeA@mail.gmail.com>
Date: Tue, 3 Feb 2026 01:00:29 +0100
From: Linus Walleij <linusw@...nel.org>
To: Luca Ceresoli <luca.ceresoli@...tlin.com>
Cc: Biju Das <biju.das.jz@...renesas.com>, 
	Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard <mripard@...nel.org>, 
	Thomas Zimmermann <tzimmermann@...e.de>, David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, 
	Anitha Chrisanthus <anitha.chrisanthus@...el.com>, 
	Laurent Pinchart <laurent.pinchart+renesas@...asonboard.com>, 
	Tomi Valkeinen <tomi.valkeinen+renesas@...asonboard.com>, 
	Kieran Bingham <kieran.bingham+renesas@...asonboard.com>, 
	Geert Uytterhoeven <geert+renesas@...der.be>, Magnus Damm <magnus.damm@...il.com>, 
	Tomi Valkeinen <tomi.valkeinen@...asonboard.com>, Hui Pu <Hui.Pu@...ealthcare.com>, 
	Ian Ray <ian.ray@...ealthcare.com>, Thomas Petazzoni <thomas.petazzoni@...tlin.com>, 
	dri-devel@...ts.freedesktop.org, linux-renesas-soc@...r.kernel.org, 
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 3/6] drm/mcde: dsi: mcde_dsi_bind: break when a panel
 or bridge is found

On Sat, Jan 31, 2026 at 4:58 PM Luca Ceresoli <luca.ceresoli@...tlin.com> wrote:

> mcde_dsi_bind() has a loop over all subnodes looking for a panel, but does
> not exit when a match is found and only stores the last match. However this
> will be problematic when introducing refcounting on the struct drm_device
> pointer in a following commit, because of_drm_find_and_get_bridge() would
> get a reference to multiple bridges.
>
> There seem to be no real reason for looking for multiple panels, so just
> break as soon as a match is found.
>
> Signed-off-by: Luca Ceresoli <luca.ceresoli@...tlin.com>

Reviewed-by: Linus Walleij <linusw@...nel.org>

Yours,
Linus Walleij