linux-kernel - Re: [PATCH v16 4/7] pkcs7: Allow the signing algo to do whatever digestion it wants itself

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2546581.1770107852@warthog.procyon.org.uk>
Date: Tue, 03 Feb 2026 08:37:32 +0000
From: David Howells <dhowells@...hat.com>
To: Jarkko Sakkinen <jarkko@...nel.org>
Cc: dhowells@...hat.com, Lukas Wunner <lukas@...ner.de>,
    Ignat Korchagin <ignat@...udflare.com>,
    Herbert Xu <herbert@...dor.apana.org.au>,
    Eric Biggers <ebiggers@...nel.org>,
    Luis Chamberlain <mcgrof@...nel.org>,
    Petr Pavlu <petr.pavlu@...e.com>, Daniel Gomez <da.gomez@...nel.org>,
    Sami Tolvanen <samitolvanen@...gle.com>,
    "Jason A . Donenfeld" <Jason@...c4.com>,
    Ard Biesheuvel <ardb@...nel.org>,
    Stephan Mueller <smueller@...onox.de>, linux-crypto@...r.kernel.org,
    keyrings@...r.kernel.org, linux-modules@...r.kernel.org,
    linux-kernel@...r.kernel.org
Subject: Re: [PATCH v16 4/7] pkcs7: Allow the signing algo to do whatever digestion it wants itself

Jarkko Sakkinen <jarkko@...nel.org> wrote:

> > +	if (!sinfo->sig->m_free) {
> > +		pr_notice_once("%s: No digest available\n", __func__);
> > +		return -EINVAL; /* TODO: MLDSA doesn't necessarily calculate an
> > +				 * intermediate digest. */
> 
> Is this logic going to change in the foreseeable future?

This is only used by IMA to retrieve an intermediate digest, so something will
need to be fixed to support use of ML-DSA in IMA, but I don't know what yet.
It doesn't, however, preclude the use of the rest of the code for module or
kexec signature verification, so I think it's reasonable enough just to emit a
warning and return an error here for now.

David