[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <d4907b57-ef8f-4357-804c-930200f57c35@oss.qualcomm.com>
Date: Tue, 3 Feb 2026 10:22:16 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Sushrut Shree Trivedi <sushrut.trivedi@....qualcomm.com>,
Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>, Rob Herring <robh@...nel.org>,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Conor Dooley <conor+dt@...nel.org>
Cc: linux-arm-msm@...r.kernel.org, devicetree@...r.kernel.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] arm64: dts: qcom:
qcs6490-rb3gen2-industrial-mezzanine: Add TC9563 PCIe switch node for PCIe0
On 2/3/26 5:31 AM, Sushrut Shree Trivedi wrote:
> Add a node for the TC9563 PCIe switch connected to PCIe0. The switch
> has three downstream ports.Two embedded Ethernet devices are present
> on one of the downstream ports. All the ports present in the
> node represent the downstream ports and embedded endpoints.
>
> Power to the TC9563 is supplied through two LDO regulators, which
> are on by default and are added as fixed regulators. TC9563 can be
> configured through I2C.
>
> Signed-off-by: Sushrut Shree Trivedi <sushrut.trivedi@....qualcomm.com>
> ---
Largely the same label comments as in patch 2
[...]
> +&{/} {
> +
> + vreg_dc_12v: regulator-vreg-dc-12v {
> + compatible = "regulator-fixed";
> + regulator-name = "VREG_DC_12V";
> +
> + regulator-always-on;
> + regulator-boot-on;
Nit: please move these boolean properties below min/max-microvolt
Konrad
Powered by blists - more mailing lists