Message-ID: <586121cf-eb31-468c-9300-e670671653e1@amd.com>
Date: Tue, 3 Feb 2026 12:07:46 +1100
From: Alexey Kardashevskiy <aik@....com>
To: Jason Gunthorpe <jgg@...pe.ca>, Sean Christopherson <seanjc@...gle.com>
Cc: Ackerley Tng <ackerleytng@...gle.com>, cgroups@...r.kernel.org,
 kvm@...r.kernel.org, linux-doc@...r.kernel.org,
 linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-kselftest@...r.kernel.org, linux-mm@...ck.org,
 linux-trace-kernel@...r.kernel.org, x86@...nel.org,
 akpm@...ux-foundation.org, binbin.wu@...ux.intel.com, bp@...en8.de,
 brauner@...nel.org, chao.p.peng@...el.com, chenhuacai@...nel.org,
 corbet@....net, dave.hansen@...el.com, dave.hansen@...ux.intel.com,
 david@...hat.com, dmatlack@...gle.com, erdemaktas@...gle.com,
 fan.du@...el.com, fvdl@...gle.com, haibo1.xu@...el.com, hannes@...xchg.org,
 hch@...radead.org, hpa@...or.com, hughd@...gle.com, ira.weiny@...el.com,
 isaku.yamahata@...el.com, jack@...e.cz, james.morse@....com,
 jarkko@...nel.org, jgowans@...zon.com, jhubbard@...dia.com, jroedel@...e.de,
 jthoughton@...gle.com, jun.miao@...el.com, kai.huang@...el.com,
 keirf@...gle.com, kent.overstreet@...ux.dev, liam.merwick@...cle.com,
 maciej.wieczor-retman@...el.com, mail@...iej.szmigiero.name,
 maobibo@...ngson.cn, mathieu.desnoyers@...icios.com, maz@...nel.org,
 mhiramat@...nel.org, mhocko@...nel.org, mic@...ikod.net,
 michael.roth@....com, mingo@...hat.com, mlevitsk@...hat.com,
 mpe@...erman.id.au, muchun.song@...ux.dev, nikunj@....com, nsaenz@...zon.es,
 oliver.upton@...ux.dev, palmer@...belt.com, pankaj.gupta@....com,
 paul.walmsley@...ive.com, pbonzini@...hat.com, peterx@...hat.com,
 pgonda@...gle.com, prsampat@....com, pvorel@...e.cz, qperret@...gle.com,
 richard.weiyang@...il.com, rick.p.edgecombe@...el.com, rientjes@...gle.com,
 rostedt@...dmis.org, roypat@...zon.co.uk, rppt@...nel.org,
 shakeel.butt@...ux.dev, shuah@...nel.org, steven.price@....com,
 steven.sistare@...cle.com, suzuki.poulose@....com, tabba@...gle.com,
 tglx@...utronix.de, thomas.lendacky@....com, vannapurve@...gle.com,
 vbabka@...e.cz, viro@...iv.linux.org.uk, vkuznets@...hat.com,
 wei.w.wang@...el.com, will@...nel.org, willy@...radead.org,
 wyihan@...gle.com, xiaoyao.li@...el.com, yan.y.zhao@...el.com,
 yilun.xu@...el.com, yuzenghui@...wei.com, zhiquan1.li@...el.com
Subject: Re: [RFC PATCH v1 05/37] KVM: guest_memfd: Wire up
 kvm_get_memory_attributes() to per-gmem attributes

On 29/1/26 12:16, Jason Gunthorpe wrote:
> On Wed, Jan 28, 2026 at 05:03:27PM -0800, Sean Christopherson wrote:
> 
>> For a dmabuf fd, the story is the same as guest_memfd.  Unless private vs. shared
>> is all or nothing, and can never change, then the only entity that can track that
>> info is the owner of the dmabuf.  And even if the private vs. shared attributes
>> are constant, tracking it external to KVM makes sense, because then the provider
>> can simply hardcode %true/%false.
> 
> Oh my I had not given that bit any thought. My remarks were just about
> normal non-CC systems.
> 
> So MMIO starts out shared, and then converts to private when the guest
> triggers it. It is not all or nothing, there are permanent shared
> holes in the MMIO ranges too.
> 
> Beyond that I don't know what people are thinking.
> 
> Clearly VFIO has to revoke and disable the DMABUF once any of it
> becomes private.

huh? Private MMIO still has to be mapped in the NPT (well, on AMD). It is the userspace mapping which we do not want^wneed and we do not by using dmabuf.

> VFIO will somehow have to know when it changes modes
> from the TSM subsystem.
> 
> I guess we could have a special channel for KVM to learn the
> shared/private page by page from VFIO as some kind of "aware of CC"
> importer.

Yilun is doing something like that in (there must be a newer version somewhere)
https://lore.kernel.org/all/20250529053513.1592088-1-yilun.xu@linux.intel.com/


> I suppose AMD needs to mangle the RMP when it changes, and KVM has to
> do that.

True.

> I forget what ARM does, but I seem to recall there is a call to create
> a vPCI function and that is what stuffs the S2? So maybe KVM isn't
> even involved? (IIRC people were talking that something else would
> call the vPCI function but I haven't seen patches)
> 
> No idea what x86 does beyond it has to unmap all the MMIO otherwise
> the machine crashes :P

When it is in the hypervisor area, there is no "x86" :)

The "AMD x86" does not crash if there are mappings which won't work, it faults/fences when these are accessed.
  
> Oh man, what a horrible mess to even contemplate. I'm going to bed.
>
> 
> Jason

-- 
Alexey

Powered by blists - more mailing lists