linux-kernel - Re: [PATCH v2 11/13] iio: imu: bmi323: remove unused drdy_trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYHDR8IS3PwXn9VF@smile.fi.intel.com>
Date: Tue, 3 Feb 2026 11:43:35 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: Antoniu Miclaus <antoniu.miclaus@...log.com>
Cc: Lars-Peter Clausen <lars@...afoo.de>,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>,
	Jagath Jog J <jagathjog1996@...il.com>,
	Subhajit Ghosh <subhajit.ghosh@...aklogic.com>,
	Matti Vaittinen <mazziesaccount@...il.com>,
	Fabio Estevam <festevam@...x.de>,
	Linus Walleij <linus.walleij@...aro.org>,
	Sakari Ailus <sakari.ailus@...ux.intel.com>,
	Marcelo Schmitt <marcelo.schmitt1@...il.com>,
	Eugene Zaikonnikov <ez@...phonic.com>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 11/13] iio: imu: bmi323: remove unused
 drdy_trigger_enabled

On Mon, Feb 02, 2026 at 01:26:01PM +0200, Antoniu Miclaus wrote:
> Remove unused drdy_trigger_enabled field from bmi323_data
> struct. The field is declared but never accessed in the
> driver.

...

> struct bmi323_data {

>  	struct iio_mount_matrix orientation;
>  	enum bmi323_irq_pin irq_pin;
>  	struct iio_trigger *trig;
> -	bool drdy_trigger_enabled;

Hmm... Not directly related to your series, but with it applied it makes sense
to revisit the structure layouts as they might be rearranged to occupy less
space.

>  	enum bmi323_state state;

For example, this enum, if moved closer to irq_pin, might result in less gap on
some architectures. (Probably not, as we use long, id est 'int' sized, enums.)

In any way, `pahole` can hint about that, but as I said, it's not for this
series.

>  	s64 fifo_tstamp, old_fifo_tstamp;
>  	u32 odrns[BMI323_SENSORS_CNT];

-- 
With Best Regards,
Andy Shevchenko