linux-kernel - Re: [PATCH v2 next 1/5] iio: sca3000: cache SPI device ID in probe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <91ba7406-b05f-4aaa-a800-b4c8cde0eeb7@oracle.com>
Date: Tue, 3 Feb 2026 15:54:23 +0530
From: Harshit Mogalapalli <harshit.m.mogalapalli@...cle.com>
To: David Lechner <dlechner@...libre.com>,
        Jonathan Cameron
 <jic23@...nel.org>,
        Nuno Sá <nuno.sa@...log.com>,
        Andy Shevchenko <andy@...nel.org>,
        Antoniu Miclaus <antoniu.miclaus@...log.com>,
        Andrew Ijano <andrew.ijano@...il.com>, linux-iio@...r.kernel.org,
        linux-kernel@...r.kernel.org
Cc: kernel-janitors@...r.kernel.org, error27@...il.com,
        andriy.shevchenko@...el.com
Subject: Re: [PATCH v2 next 1/5] iio: sca3000: cache SPI device ID in probe

Hi David,

On 03/02/26 04:31, David Lechner wrote:
> On 2/2/26 1:40 PM, Harshit Mogalapalli wrote:
>> Store the spi_device_id at probe entry and reuse it for the name and
>> chip info instead of calling spi_get_device_id() repeatedly.
> 
> Even better would be to replace spi_get_device_id() with
> pi_get_device_match_data() and turn sca3000_spi_chip_info_tbl[]
> into individual structs that are used directly as the match
> data pointers.
>

Thanks for the review.

Jonathan also suggested this on v1, but thought of doing this item 
separate to this patch series(as its a functional change) , would you 
mind if I do it in a separate patch after this series ?


>>
>> Reuse the local dev pointer for resource managed helpers. While at it,
>> reshuffle variable list in a reverse Christmas tree order.
> 
> The dev cleanup sounds like a second unrelated change that can be split
> out from the spi_get_device_id() changes.
> 

Sure I will separate dev cleanup and device_id extraction into separate 
patches.

Thanks for the suggestion.

Regards,
Harshit