linux-kernel - Re: [RESEND PATCH] gfs2: do not evict glocks with populated address spaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20260203114257.25469-1-trintaeoitogc@gmail.com>
Date: Tue,  3 Feb 2026 08:42:57 -0300
From: Guilherme Giacomo Simoes <trintaeoitogc@...il.com>
To: agruenba@...hat.com
Cc: gfs2@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	trintaeoitogc@...il.com
Subject: Re: [RESEND PATCH] gfs2: do not evict glocks with populated address spaces

Andreas Gruenbacher <agruenba@...hat.com> wrote:
> > Metadata glocks may have associated address spaces used as caches. Avoid
> > reclaiming such glocks under memory pressure while their mappings are
> > still populated or their state is not unlocked, as this can lead to
> > invalid page cache state and GLOCK_BUG_ON().
> 
> What invalid page cache state and GLOCK_BUG_ON() errors is this about, exactly?
On __gfs2_glock_put() (fs/gfs2/glock.c) the GLOCK_BUG_ON() is triggered under
memory pressure while the glock is still locked or the glock is populated with
metadata caches.

This happens because the __gfs2_glock_put() can't truncate pages with a private
datas (truncate_inode_pages_final(mapping) is failed), how the metadata is a
private folio, the	GLOCK_BUG_ON(gl, !mapping_empty(mapping)) is trigged.

> This leaks a glock reference, so it's definitely wrong.
But this glock is a private folio with metadata or is still locked. I think
this can't be evictable