linux-kernel - Re: [PATCH] fs/tests: exec: drop duplicate bprm_stack

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <202602031722.72C5EBFF15@keescook>
Date: Tue, 3 Feb 2026 17:36:24 -0800
From: Kees Cook <kees@...nel.org>
To: Titouan Ameline de Cadeville <titouan.ameline@...il.com>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] fs/tests: exec: drop duplicate bprm_stack_limits test
 vectors

On Tue, Feb 03, 2026 at 06:59:50PM +0100, Titouan Ameline de Cadeville wrote:
> Remove duplicate entries from the bprm_stack_limits KUnit test vector
> table. The duplicates do not add coverage and only increase test size.

Hm, yes, these are pointless duplicates. It makes me think I typo'd
something here.

> Signed-off-by: Titouan Ameline de Cadeville <titouan.ameline@...il.com>

Regardless:

Fixes: 60371f43e56b ("exec: Add KUnit test for bprm_stack_limits()")

> ---
>  fs/tests/exec_kunit.c | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/fs/tests/exec_kunit.c b/fs/tests/exec_kunit.c
> index 7c77d039680b..f412d1a0f6bb 100644
> --- a/fs/tests/exec_kunit.c
> +++ b/fs/tests/exec_kunit.c
> @@ -87,9 +87,6 @@ static const struct bprm_stack_limits_result bprm_stack_limits_results[] = {
>  	    .argc = 0, .envc = ARG_MAX / sizeof(void *) - 1 },
>  	  .expected_argmin = ULONG_MAX - sizeof(void *) },
>  	/* Raising rlim_stack / 4 to _STK_LIM / 4 * 3 will see more space. */
> -	{ { .p = ULONG_MAX, .rlim_stack.rlim_cur = 4 * (_STK_LIM / 4 * 3),
> -	    .argc = 0, .envc = 0 },
> -	  .expected_argmin = ULONG_MAX - (_STK_LIM / 4 * 3) + sizeof(void *) },
>  	{ { .p = ULONG_MAX, .rlim_stack.rlim_cur = 4 * (_STK_LIM / 4 * 3),
>  	    .argc = 0, .envc = 0 },
>  	  .expected_argmin = ULONG_MAX - (_STK_LIM / 4 * 3) + sizeof(void *) },

Looking at the surrounding tests and trying to jog my memory, I think I
meant to have differing envc values here, but that turned out not to be
useful: I wanted to test the impact of rlim_stack.rlim_cur, not
argc/envc here.

> @@ -103,9 +100,6 @@ static const struct bprm_stack_limits_result bprm_stack_limits_results[] = {
>  	{ { .p = ULONG_MAX, .rlim_stack.rlim_cur = 4 * _STK_LIM,
>  	    .argc = 0, .envc = 0 },
>  	  .expected_argmin = ULONG_MAX - (_STK_LIM / 4 * 3) + sizeof(void *) },
> -	{ { .p = ULONG_MAX, .rlim_stack.rlim_cur = 4 * _STK_LIM,
> -	    .argc = 0, .envc = 0 },
> -	  .expected_argmin = ULONG_MAX - (_STK_LIM / 4 * 3) + sizeof(void *) },

Same here.

Reviewed-by: Kees Cook <kees@...nel.org>

-- 
Kees Cook