linux-kernel - Re: [PATCH] timers/migration: Ensure proper resource cleanup on error in tmigr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <87sebg1r89.ffs@tglx>
Date: Wed, 04 Feb 2026 16:08:22 +0100
From: Thomas Gleixner <tglx@...nel.org>
To: Zhan Xusheng <zhanxusheng1024@...il.com>, Anna-Maria Behnsen
 <anna-maria@...utronix.de>
Cc: linux-kernel@...r.kernel.org, Zhan Xusheng <zhanxusheng@...omi.com>
Subject: Re: [PATCH] timers/migration: Ensure proper resource cleanup on
 error in tmigr_init

On Wed, Feb 04 2026 at 16:50, Zhan Xusheng wrote:
> Free resources allocated by zalloc_cpumask_var and kcalloc on failure.
>
> Signed-off-by: Zhan Xusheng <zhanxusheng@...omi.com>
> ---
>  kernel/time/timer_migration.c | 12 +++++++++---
>  1 file changed, 9 insertions(+), 3 deletions(-)
>
> diff --git a/kernel/time/timer_migration.c b/kernel/time/timer_migration.c
> index 18dda1aa782d..c2b3aa6946c1 100644
> --- a/kernel/time/timer_migration.c
> +++ b/kernel/time/timer_migration.c
> @@ -1994,7 +1994,7 @@ static int __init tmigr_init(void)
>  
>  	tmigr_level_list = kcalloc(tmigr_hierarchy_levels, sizeof(struct list_head), GFP_KERNEL);
>  	if (!tmigr_level_list)
> -		goto err;
> +		goto err_free_cpumask;
>  
>  	for (i = 0; i < tmigr_hierarchy_levels; i++)
>  		INIT_LIST_HEAD(&tmigr_level_list[i]);
> @@ -2007,15 +2007,21 @@ static int __init tmigr_init(void)
>  	ret = cpuhp_setup_state(CPUHP_TMIGR_PREPARE, "tmigr:prepare",
>  				tmigr_cpu_prepare, NULL);
>  	if (ret)
> -		goto err;
> +		goto err_free_level_list;
>  
>  	ret = cpuhp_setup_state(CPUHP_AP_TMIGR_ONLINE, "tmigr:online",
>  				tmigr_set_cpu_available, tmigr_clear_cpu_available);
>  	if (ret)
> -		goto err;
> +		goto err_free_level_list;

Which leaves the prepare hotplug state registered ....

>  	return 0;
>  
> +err_free_level_list:
> +	kfree(tmigr_level_list);
> +
> +err_free_cpumask:
> +	free_cpumask_var(tmigr_available_cpumask);
> +
>  err:
>  	pr_err("Timer migration setup failed\n");
>  	return ret;