linux-kernel - Re: [PATCH 4/6] rust: io: remove legacy relaxed accessors of Mmio

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <7E5C2D1B-C876-4F73-A497-338128F38E59@collabora.com>
Date: Wed, 4 Feb 2026 12:19:52 -0300
From: Daniel Almeida <daniel.almeida@...labora.com>
To: Alexandre Courbot <acourbot@...dia.com>
Cc: Danilo Krummrich <dakr@...nel.org>,
 Alice Ryhl <aliceryhl@...gle.com>,
 Miguel Ojeda <ojeda@...nel.org>,
 Boqun Feng <boqun.feng@...il.com>,
 Gary Guo <gary@...yguo.net>,
 Björn Roy Baron <bjorn3_gh@...tonmail.com>,
 Benno Lossin <lossin@...nel.org>,
 Andreas Hindborg <a.hindborg@...nel.org>,
 Trevor Gross <tmgross@...ch.edu>,
 Bjorn Helgaas <bhelgaas@...gle.com>,
 Krzysztof Wilczyński <kwilczynski@...nel.org>,
 driver-core@...ts.linux.dev,
 rust-for-linux@...r.kernel.org,
 linux-kernel@...r.kernel.org,
 linux-pci@...r.kernel.org,
 Zhi Wang <zhiw@...dia.com>,
 Lyude Paul <lyude@...hat.com>,
 Eliot Courtney <ecourtney@...dia.com>
Subject: Re: [PATCH 4/6] rust: io: remove legacy relaxed accessors of Mmio



> On 2 Feb 2026, at 05:13, Alexandre Courbot <acourbot@...dia.com> wrote:
> 
> The relaxed access functionality is now provided by the `RelaxedMmio`
> wrapper type, and we don't have any user of the legacy methods left.
> Remove them.
> 
> Signed-off-by: Alexandre Courbot <acourbot@...dia.com>
> ---
> rust/kernel/io.rs | 40 ----------------------------------------
> 1 file changed, 40 deletions(-)
> 
> diff --git a/rust/kernel/io.rs b/rust/kernel/io.rs
> index baa8d3baa20c..e1094a237ff7 100644
> --- a/rust/kernel/io.rs
> +++ b/rust/kernel/io.rs
> @@ -660,46 +660,6 @@ pub unsafe fn from_raw(raw: &MmioRaw<SIZE>) -> &Self {
>         // SAFETY: `Mmio` is a transparent wrapper around `MmioRaw`.
>         unsafe { &*core::ptr::from_ref(raw).cast() }
>     }
> -
> -    define_read!(infallible, pub read8_relaxed, call_mmio_read(readb_relaxed) -> u8);
> -    define_read!(infallible, pub read16_relaxed, call_mmio_read(readw_relaxed) -> u16);
> -    define_read!(infallible, pub read32_relaxed, call_mmio_read(readl_relaxed) -> u32);
> -    define_read!(
> -        infallible,
> -        #[cfg(CONFIG_64BIT)]
> -        pub read64_relaxed,
> -        call_mmio_read(readq_relaxed) -> u64
> -    );
> -
> -    define_read!(fallible, pub try_read8_relaxed, call_mmio_read(readb_relaxed) -> u8);
> -    define_read!(fallible, pub try_read16_relaxed, call_mmio_read(readw_relaxed) -> u16);
> -    define_read!(fallible, pub try_read32_relaxed, call_mmio_read(readl_relaxed) -> u32);
> -    define_read!(
> -        fallible,
> -        #[cfg(CONFIG_64BIT)]
> -        pub try_read64_relaxed,
> -        call_mmio_read(readq_relaxed) -> u64
> -    );
> -
> -    define_write!(infallible, pub write8_relaxed, call_mmio_write(writeb_relaxed) <- u8);
> -    define_write!(infallible, pub write16_relaxed, call_mmio_write(writew_relaxed) <- u16);
> -    define_write!(infallible, pub write32_relaxed, call_mmio_write(writel_relaxed) <- u32);
> -    define_write!(
> -        infallible,
> -        #[cfg(CONFIG_64BIT)]
> -        pub write64_relaxed,
> -        call_mmio_write(writeq_relaxed) <- u64
> -    );
> -
> -    define_write!(fallible, pub try_write8_relaxed, call_mmio_write(writeb_relaxed) <- u8);
> -    define_write!(fallible, pub try_write16_relaxed, call_mmio_write(writew_relaxed) <- u16);
> -    define_write!(fallible, pub try_write32_relaxed, call_mmio_write(writel_relaxed) <- u32);
> -    define_write!(
> -        fallible,
> -        #[cfg(CONFIG_64BIT)]
> -        pub try_write64_relaxed,
> -        call_mmio_write(writeq_relaxed) <- u64
> -    );
> }
> 
> /// [`Mmio`] wrapper using relaxed accessors.
> 
> -- 
> 2.52.0
> 
> 

Reviewed-by: Daniel Almeida <daniel.almeida@...labora.com>