linux-kernel - Re: [PATCH v2 6/6] irqchip/renesas-rzv2h: Handle ICU error IRQ and add SWPE trigger

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CA+V-a8tyB-5c8MoySoDDgmMW-zm5N3OhfMrcgjuKk5p1rr4sAw@mail.gmail.com>
Date: Wed, 4 Feb 2026 15:44:36 +0000
From: "Lad, Prabhakar" <prabhakar.csengg@...il.com>
To: Thomas Gleixner <tglx@...nel.org>
Cc: Philipp Zabel <p.zabel@...gutronix.de>, Geert Uytterhoeven <geert+renesas@...der.be>, 
	Magnus Damm <magnus.damm@...il.com>, linux-kernel@...r.kernel.org, 
	linux-renesas-soc@...r.kernel.org, Biju Das <biju.das.jz@...renesas.com>, 
	Fabrizio Castro <fabrizio.castro.jz@...esas.com>, 
	Lad Prabhakar <prabhakar.mahadev-lad.rj@...renesas.com>
Subject: Re: [PATCH v2 6/6] irqchip/renesas-rzv2h: Handle ICU error IRQ and
 add SWPE trigger

Hi Thomas,

Thank you for the review.

On Wed, Feb 4, 2026 at 3:22 PM Thomas Gleixner <tglx@...nel.org> wrote:
>
> On Tue, Feb 03 2026 at 23:18, Prabhakar wrote:
> > +     /* 1) Bus errors (BEISR0..3) */
> > +     for (k = 0; k < ICU_NUM_BE; k++) {
> > +             st = readl(base + ICU_BEISR(k));
> > +             if (!st)
> > +                     continue;
> > +
> > +             writel_relaxed(st, base + ICU_BECLR(k));
> > +             pr_debug("rzv2h-icu: BUS error k=%u status=0x%08x\n", k, st);
>
> Why hiding this behind pr_debug()? That's all diagnostic information
> which helps to monitor system health, no?
>
Agreed, I'll change it to pr_info() (and do the same for patch 5/6)

Cheers,
Prabhakar