linux-kernel - Re: [PATCH v14 1/9] rust: types: Add Ownable/Owned types

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87fr7gpk6d.fsf@t14s.mail-host-address-is-not-set>
Date: Wed, 04 Feb 2026 17:06:50 +0100
From: Andreas Hindborg <a.hindborg@...nel.org>
To: Danilo Krummrich <dakr@...nel.org>
Cc: Miguel Ojeda <ojeda@...nel.org>, Boqun Feng <boqun.feng@...il.com>, Gary
 Guo <gary@...yguo.net>, Björn Roy Baron
 <bjorn3_gh@...tonmail.com>, Benno
 Lossin <lossin@...nel.org>, Alice
 Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, Greg
 Kroah-Hartman <gregkh@...uxfoundation.org>, Dave Ertman
 <david.m.ertman@...el.com>, Ira Weiny <ira.weiny@...el.com>, Leon
 Romanovsky <leon@...nel.org>, Paul Moore <paul@...l-moore.com>, Serge
 Hallyn <sergeh@...nel.org>, "Rafael J. Wysocki" <rafael@...nel.org>, David
 Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>, Alexander
 Viro <viro@...iv.linux.org.uk>, Christian Brauner <brauner@...nel.org>,
 Jan Kara <jack@...e.cz>, Igor Korotin <igor.korotin.linux@...il.com>,
 Daniel Almeida <daniel.almeida@...labora.com>, Lorenzo Stoakes
 <lorenzo.stoakes@...cle.com>, "Liam R. Howlett" <Liam.Howlett@...cle.com>,
 Viresh Kumar <vireshk@...nel.org>, Nishanth Menon <nm@...com>, Stephen
 Boyd <sboyd@...nel.org>, Bjorn Helgaas <bhelgaas@...gle.com>, Krzysztof
 Wilczyński <kwilczynski@...nel.org>,
 linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org, linux-block@...r.kernel.org,
 linux-security-module@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 linux-fsdevel@...r.kernel.org, linux-mm@...ck.org,
 linux-pm@...r.kernel.org, linux-pci@...r.kernel.org, Asahi Lina
 <lina+kernel@...hilina.net>
Subject: Re: [PATCH v14 1/9] rust: types: Add Ownable/Owned types

"Danilo Krummrich" <dakr@...nel.org> writes:

> On Wed Feb 4, 2026 at 12:56 PM CET, Andreas Hindborg wrote:
>> From: Asahi Lina <lina+kernel@...hilina.net>
>>
>> By analogy to `AlwaysRefCounted` and `ARef`, an `Ownable` type is a
>> (typically C FFI) type that *may* be owned by Rust, but need not be. Unlike
>> `AlwaysRefCounted`, this mechanism expects the reference to be unique
>> within Rust, and does not allow cloning.
>>
>> Conceptually, this is similar to a `KBox<T>`, except that it delegates
>> resource management to the `T` instead of using a generic allocator.
>>
>> This change is a derived work based on work by Asahi Lina
>> <lina+kernel@...hilina.net> [1] and Oliver Mangold <oliver.mangold@...me>.
>>
>> Link: https://lore.kernel.org/rust-for-linux/20250202-rust-page-v1-1-e3170d7fe55e@asahilina.net/ [1]
>> Signed-off-by: Andreas Hindborg <a.hindborg@...nel.org>
>
> Given the From: line above, this needs Lina's SoB.
>
> This patch was also originally posted by Abdiel and Boqun and I think we should
> account for this. I mentioned this in a couple of previous versions already,
> e.g. in [1]. I think we should account for this.
>
> [1] https://lore.kernel.org/all/cc28d048-5e0f-4f0e-b0f2-1b9e240f639b@kernel.org/

I had a question about this in the cover letter.

It is my understanding that the SoB needs confirmation from the author
if the code was changed. I changed the code and did not want to bother
the original author, because it is my understanding they do not wish to
be contacted. I did not want to misrepresent the original author, and so
I did not change the "From:" line.

I want to be clear that I want to submit this patch the correct way,
whatever that is. I will happily take all the guidance I can get to find
the correct way to represent the work of the original author(s).

How would you prefer to account for the work by Abdiel and Boqun?

Please advise about SoB and I will correct the series.

Best regards,
Andreas Hindborg