lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <9f2759ae-58c0-437a-8439-5b75fa036da3@intel.com>
Date: Wed, 4 Feb 2026 08:08:52 -0800
From: Reinette Chatre <reinette.chatre@...el.com>
To: Ben Horgan <ben.horgan@....com>, <linux-kernel@...r.kernel.org>
CC: <tony.luck@...el.com>, <Dave.Martin@....com>, <james.morse@....com>,
	<babu.moger@....com>, <bp@...en8.de>
Subject: Re: [PATCH v3] fs/resctrl: Add CONFIG_RESCTRL_ASSIGN_FIXED Kconfig
 entry

Hi Ben,

On 2/4/26 4:02 AM, Ben Horgan wrote:
> Commit
> 
>   3b497c3f4f04 ("fs/resctrl: Introduce the interface to display monitoring modes")
> 
> introduced CONFIG_RESCTRL_ASSIGN_FIXED but left adding the Kconfig entry
> until it was necessary.

The changelog flow makes a big leap between its two paragraphs. I cannot tell why the
middle paragraph was dropped since it describes why the change is needed now to connect
with the opening context. Could you add a middle paragraph like below?

  Add CONFIG_RESCTRL_ASSIGN_FIXED in order to support MPAM where the counter assignment
  mode is indeed fixed. 

> 
> CONFIG_RESCTRL_ASSIGN_FIXED is a resctrl fs Kconfig option so handle
> attempts to modify counter assignment mode when it is enabled in resctrl fs
> rather than delegating to arch specific code.
> 
> Signed-off-by: Ben Horgan <ben.horgan@....com>
> ---
Reinette

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ