linux-kernel - Re: [PATCH v3 6/9] iio: amplifiers: ad8366: sort header includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aYKnu8_fEdXGIahE@smile.fi.intel.com>
Date: Wed, 4 Feb 2026 03:58:19 +0200
From: Andy Shevchenko <andriy.shevchenko@...el.com>
To: rodrigo.alencar@...log.com
Cc: linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org,
	Michael Hennerich <Michael.Hennerich@...log.com>,
	Lars-Peter Clausen <lars@...afoo.de>,
	Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>
Subject: Re: [PATCH v3 6/9] iio: amplifiers: ad8366: sort header includes

On Tue, Feb 03, 2026 at 11:24:12AM +0000, Rodrigo Alencar via B4 Relay wrote:

> Alphabetically sort include directives and drop include of linux/kernel.h.

Is it safe to be dropped? Do we have all necessary headers included?

...

> -#include <linux/device.h>
> -#include <linux/kernel.h>
> -#include <linux/slab.h>
> -#include <linux/sysfs.h>
> -#include <linux/spi/spi.h>
> -#include <linux/regulator/consumer.h>
> -#include <linux/gpio/consumer.h>
> -#include <linux/err.h>
> -#include <linux/module.h>
>  #include <linux/bitrev.h>

> -

No, please keep linux/iio/* in a separate group after linux/*.

> +#include <linux/device.h>

What about this one? If you dropped kernel.h, do you really need device.h?

> +#include <linux/err.h>
> +#include <linux/gpio/consumer.h>
>  #include <linux/iio/iio.h>
>  #include <linux/iio/sysfs.h>
> +#include <linux/module.h>
> +#include <linux/regulator/consumer.h>
> +#include <linux/slab.h>
> +#include <linux/spi/spi.h>
> +#include <linux/sysfs.h>

...

I suggest to split this to two patches:
1) just pure sorting;
2) converting in accordance with IWYU principle.


-- 
With Best Regards,
Andy Shevchenko