linux-kernel - Re: [PATCH net-next v1] icmp: fix ip_rt_bug race in icmp_route

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <3d7fd4c1-4519-49b1-88df-5770734e8a72@kernel.org>
Date: Wed, 4 Feb 2026 09:29:19 -0700
From: David Ahern <dsahern@...nel.org>
To: Jiayuan Chen <jiayuan.chen@...ux.dev>, Paolo Abeni <pabeni@...hat.com>,
 netdev@...r.kernel.org
Cc: Jiayuan Chen <jiayuan.chen@...pee.com>,
 syzbot+e738404dcd14b620923c@...kaller.appspotmail.com,
 "David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
 Jakub Kicinski <kuba@...nel.org>, Simon Horman <horms@...nel.org>,
 Herbert Xu <herbert@...dor.apana.org.au>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next v1] icmp: fix ip_rt_bug race in icmp_route_lookup
 reverse path

On 2/3/26 7:27 PM, Jiayuan Chen wrote:
> 
> Thanks for the review.
> 
> Paolo, I'll fix it in newer version.
> 
> Regarding David's question about whether the message provides value:
> I think it could still be useful for debugging. If a user's configuration
> change causes ICMP packets to be silently dropped, there's currently no counter
> or indication of what happened. Adding a dedicated counter for this rare race
> condition seems overkill, so a rate-limited warning at least gives some visibility
> into the failure.
> 
> That said, I'm open to dropping the message entirely if you both think silent handling
> is preferred. Let me know and I'll send a new version either way.
> 

no strong opinions.