linux-kernel - Re: [PATCH v2 2/4] spi: geni-qcom: Fix abort sequence execution for serial engine errors

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3ec4b87c-f967-41c0-805d-27c62093e990@oss.qualcomm.com>
Date: Wed, 4 Feb 2026 18:02:13 +0100
From: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
To: Praveen Talari <praveen.talari@....qualcomm.com>,
        Mark Brown <broonie@...nel.org>, linux-arm-msm@...r.kernel.org,
        linux-spi@...r.kernel.org, linux-kernel@...r.kernel.org,
        bjorn.andersson@....qualcomm.com, dmitry.baryshkov@....qualcomm.com
Cc: prasad.sodagudi@....qualcomm.com, mukesh.savaliya@....qualcomm.com,
        quic_vtanuku@...cinc.com, aniket.randive@....qualcomm.com,
        chandana.chiluveru@....qualcomm.com, jyothi.seerapu@....qualcomm.com
Subject: Re: [PATCH v2 2/4] spi: geni-qcom: Fix abort sequence execution for
 serial engine errors

On 2/4/26 5:28 PM, Praveen Talari wrote:
> The driver currently skips the abort sequence for target mode when serial
> engine errors occur. This leads to improper error recovery as the serial
> engine may remain in an undefined state without proper cleanup, potentially
> causing subsequent operations to fail or behave unpredictably.
> 
> Fix this by ensuring the abort sequence and DMA reset always execute during
> error recovery, as both are required for proper serial engine error
> handling.
> 
> Co-developed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>
> Signed-off-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>

Well I never left such a tag, but let's say I won't object too much..

(it potentially carries legal meaning)

it's fine not to leave any sort of attribution for small changes or
suggestions you receive during review, perhaps suggested-by if someone
says "oh btw could you please look into fixing x in xyz.c too"

for the code:

Reviewed-by: Konrad Dybcio <konrad.dybcio@....qualcomm.com>

Konrad